Re: Retiring

2021-01-13 Thread Kevin Funk
I.e.: Take your well earned break and come back whenever it suites you > again! +100. I can relate to that :) Thanks for all the enduring work you did for KDE, Christoph! Come back when time permits it again! Cheers, Kevin > Cheers -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: CuteHMI in kdereview

2020-02-15 Thread Kevin Funk
> > Albert > >> > >> CuteHMI is meant to be a set of tools and components that help one to > >> create QML-based HMI/SCADA software. > >> > >> The project has been started few years ago, because I couldn't find any > >> open-source, QML-based HMI/SCADA framework I could put my things into. > >> > >> Regards > >> > >> Michal Policht -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: KDiff3 craft setup

2019-03-07 Thread Kevin Funk
On Tuesday, 5 March 2019 21:11:11 CET Albert Astals Cid wrote: > El dimarts, 19 de febrer de 2019, a les 7:35:58 CET, Kevin Funk va escriure: > > On Monday, 18 February 2019 17:06:25 CET Michael Reeves wrote: > > > https://download.kde.org/stable/applications/18.12.1/src/kdiff3-

Re: KDiff3 craft setup

2019-02-18 Thread Kevin Funk
ollow the same versioning. Hey, Anyhow, to help you out on that regard: You'll want to check out craft-blueprints-kde.git, and there find the kdiff3 subfolder. You'll probably need to add a separate version.ini file there with custom versions/urls. See e.g. kmymoney/version.ini as ex

Re: KDiff3 craft setup

2019-02-18 Thread Kevin Funk
g to see drastic UI changes on weekly basis which need to get out to users ASAP. At least for kdiff3 I'd rather have a conservative approach in that regard, since it's a complex tool by definition. -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Importing kdiff3 - was - Re: Aw: Re: KDE inclusion

2018-01-26 Thread Kevin Funk
x27;outsider', how do you > > find > > a random person to be your incubator guy? Because as it happens, it's the > > second time in a month or something that i have to volunteer. > > Ah! That is interesting feedback. You're correct that we're currently > as

Re: Importing kdiff3 - was - Re: Aw: Re: KDE inclusion

2018-01-24 Thread Kevin Funk
On Wednesday, 24 January 2018 16:24:10 CET Michael Reeves wrote: > A little confused on where to start with this sponsor thing. Huh? 'sponsor thing'? :) Care to elaborate what you mean? Regards, Kevin > On Jan 19, 2018 3:52 PM, "Kevin Funk" wrote: > > On Wed

Re: Importing kdiff3 - was - Re: Aw: Re: KDE inclusion

2018-01-19 Thread Kevin Funk
generally follows our rules & procedures. > > I understand you want to continue maintaining the new kdiff3 and you are not > just "dumping it" into us, right? > > > Cheers, > Albert > > El divendres, 12 de gener de 2018, a les 1:21:02 CET, Joa

Re: KDE inclusion

2018-01-11 Thread Kevin Funk
. Kudos for doing the KF5 port! Regards, Kevin -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: How is symbol visibility set in KF5 and KDE?

2017-11-15 Thread Kevin Funk
SIBILITY_PRESET hidden) 225:set(CMAKE_VISIBILITY_INLINES_HIDDEN 1) Regards, Kevin > Thanks, Shaheed > > [1] I'm also a bit mystified by the fact that I am deliberately querying > CMake for the COMPILE_FLAGS to use, but I have not seen -fvisibility > anywhere... -- Kevin Fun

Re: liquidshell in kdereview

2017-11-06 Thread Kevin Funk
g-term, where we really have a hard time finding contributors for the majority of our *existing* projects. Regards, Kevin > > Best regards/Schöne Grüße > > > > Martin > > A: Because it breaks the logical sequence of discussion > > Q: Why is top posting bad? > > >

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Kevin Funk
> On July 31, 2017, 9:11 a.m., Kevin Funk wrote: > > processui/ksysguardprocesslist.cpp, line 354 > > <https://git.reviewboard.kde.org/r/128854/diff/3/?file=498252#file498252line354> > > > > Why this? > > Gregor Mi wrote: > When I try to capt

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-07-31 Thread Kevin Funk
oard.kde.org/r/128854/#comment68895> Why this? - Kevin Funk On July 28, 2017, 12:20 p.m., Gregor Mi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git

Re: What's kde-core-devel for?

2016-12-15 Thread Kevin Funk
ns). This should get less and less by time, let's move that over to kde-devel@ until it's 'dead'. Cheers, Kevin > What do people that read this list think? > > Cheers, > Albert -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

2016-11-17 Thread Kevin Funk
f a sprint) to port those. Consider me in as well. Cheers, Kevin > Greetings, > Sven -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

api.kde.org: Logs?

2016-03-24 Thread Kevin Funk
Heya, I'm trying to figure out why certain KDevelop apidocs are missing from api.kde.org. Where are the logs? Someone on IRC told me there should be: http://api.kde.org/logs/ -> 404 Ideas? Cheers -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: T

Re: Review Request 127425: Fix kcoreaddons build with threads

2016-03-19 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127425/#review93722 --- Ship it! Ship It! - Kevin Funk On March 19, 2016, 2:22

Re: [kde-community] Sunsetting of Infrastructure and the Phabricator migration

2016-03-19 Thread Kevin Funk
e power to create general purpose mainline repositories > > (and certain other actions within Phabricator) to a number of > > community members. They will be contacted individually over the next > > month or two regarding this. > > > > Comments on the above are welco

Re: Product versions on bugs.kde.org

2016-03-08 Thread Kevin Funk
On Wednesday, March 9, 2016 1:27:47 AM CET Alexander Potashev wrote: > 2016-03-09 1:09 GMT+03:00 Kevin Funk : > > Added all versions from 5.5.0 to 5.19.0. > > > > I've used this little gem here to "hammer" BKO: > > http://paste.ubuntu.com/15330672/ >

Re: Product versions on bugs.kde.org

2016-03-08 Thread Kevin Funk
On Monday, March 7, 2016 1:23:01 PM CET Kevin Funk wrote: > On Monday, March 7, 2016 11:10:13 AM CET Jonathan Riddell wrote: > > On Mon, Mar 07, 2016 at 09:25:40AM +0100, Kevin Funk wrote: > > > Is there a way to batch-modify those versions? Obviously noone wants to > >

Re: Product versions on bugs.kde.org

2016-03-07 Thread Kevin Funk
On Monday, March 7, 2016 11:10:13 AM CET Jonathan Riddell wrote: > On Mon, Mar 07, 2016 at 09:25:40AM +0100, Kevin Funk wrote: > > Is there a way to batch-modify those versions? Obviously noone wants to go > > through the Bugzilla UI, adding versions one-by-one for each(!) framework

Product versions on bugs.kde.org

2016-03-07 Thread Kevin Funk
se for frameworks, same applies to KDE Applications, etc. Cheers, Kevin [1] http://blog.asymptotic.co.uk/software-development-log/batch-modifying-bugzilla-milestones/ -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

2015-09-14 Thread Kevin Funk
tentially catch more > bugs/regressions. > > Comments? > > Cheers, > Albert Sounds good to me. We should try it out. Worth the slowdown of the ASAN-enabled programs on the CI. Cheers -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Best-practise currently for testing internal parts of libs? *_TEST_EXPORT macro?

2015-08-31 Thread Kevin Funk
ce lxr.kde.org pointed out to use the *TEST_EXPORT approach > > was > > grantlee, which simply creates a separate file with the define that then > > is > > appended to the file generated with generate_export_header: > > http://lxr.kde.org/source/grantlee/templates/lib

Re: Review Request 122556: Bump Qt version to 5.4

2015-02-13 Thread Kevin Funk
> On Feb. 13, 2015, 8:41 a.m., Martin Gräßlin wrote: > > AFAIK our CI system doesn't support Qt 5.4 yet. I think we should first > > ensure the CI system is prepared for building with the new dependency. > > Albert Astals Cid wrote: > It does > http://build.kde.org/job/kde-baseapps_mast

Re: Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

2015-02-11 Thread Kevin Funk
emove the duplicate ones in other CMakeLists.txt files. - Kevin Funk On Feb. 11, 2015, 9:43 p.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Build dependency issues with kdesrc-build

2015-02-07 Thread Kevin Funk
On Friday 06 February 2015 19:46:28 Michael Pyne wrote: > On Fri, February 6, 2015 15:11:22 Kevin Funk wrote: > > On Thursday 05 February 2015 22:16:54 Michael Pyne wrote: > > > However as of now it only reorders modules you pull into the build list, > > > so >

Re: Build dependency issues with kdesrc-build

2015-02-06 Thread Kevin Funk
ormation about the actual package dependencies pretty precisely, no? (Otherwise the whole CI infrastructure wouldn't work -- Our CI scripts can figure out the exact dependency set needed for a build) > You don't even need > to use kf5-*-build-include, you can make your own kdesrc

Re: make uninstall

2015-01-30 Thread Kevin Funk
ject basis in the KDE domain. Newcomers probably don't need to know about that target, thus, if they don't know they cannot use it and cause harm to their files anyway. Also, the name "uninstall" indicates it's a destructive operation, so you have been warned. +1 for defining this by default > > Alex -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Triggering rebuild after changing a *.json file

2014-11-23 Thread Kevin Funk
On Sunday 23 November 2014 23:37:45 Kevin Funk wrote: > On Sunday 23 November 2014 17:54:21 Milian Wolff wrote: > > On Sunday 23 November 2014 10:39:02 Andreas Pakulat wrote: > > > Hi, > > > > > > On Sun, Nov 23, 2014 at 4:36 AM, Milian Wolff wrote: > >

Re: Triggering rebuild after changing a *.json file

2014-11-23 Thread Kevin Funk
; the input and output files of the desktop-to-json conversion so a custom > > target should be easily doable (unlike automoc). > > This might be true, yes. Note that I just copied that line from > desktop_to_json. But note that in the ideal case, we wouldn't have any > desktop-to-json. Rather, we just have a *.json file, a *.cpp file that uses > K_PLUGIN_FACTORY_WITH_JSON. Currently, when the *.json file is changed, the > *.cpp.o is not updated, nor the plugin *.so rebuilt and thus the new strings > are not available at runtime. > > This is what we need to fix somehow, and I still don't know how. Will we > have to fix this inside CMake? Seems like a job for OBJECT_DEPENDS... That would require you to explicitly name the .cpp containing the K_PLUGIN_FACTORY_WITH_JSON(...) use, though. Something along: SET_SOURCE_FILES_PROPERTIES(myplugin.cpp PROPERTIES OBJECT_DEPENDS myplugin.json) http://www.cmake.org/cmake/help/v2.8.12/cmake.html#prop_sf%3aOBJECT_DEPENDS Greets PS: Thanks for providing a kdevplatform_add_plugin macro (awesome!) -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: desktoptojson and list properties / i18n of JSON files

2014-11-18 Thread Kevin Funk
body point me to such a .json file > we'd like to translate? Here's one: http://pastebin.kde.org/p4p38fqr1 That's kdevpatchreview.json, generated from kdevpatchreview.desktop via kcoreaddons_desktop_to_json(...) during the CMake run. Cheers -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Kevin Funk
=331724. - Kevin Funk On June 18, 2014, 9:51 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-03-05 Thread Kevin Funk
. Noone worked on this for years now. Personally I'd just get rid off the debug output, seems like noone cares anyway. (I'm also annoyed by the useless output) - Kevin Funk On Jan. 28, 2014, 1 p.m., Milian Wolff wrote: > >

Re: KZoneAllocator static in KCompletion crashes on exit

2014-02-10 Thread Kevin Funk
Am Montag, 10. Februar 2014, 20:38:15 schrieb Albert Astals Cid: > El Dilluns, 10 de febrer de 2014, a les 12:14:31, Kevin Funk va escriure: > > Am Montag, 10. Februar 2014, 01:28:03 schrieb Thomas Lübking: > > > On Sonntag, 9. Februar 2014 22:16:16 CEST, Albert Astals Cid wrote

Re: KZoneAllocator static in KCompletion crashes on exit

2014-02-10 Thread Kevin Funk
turned into 'static QSharedPointer alloc' member and KCompTreeNode instances are now keeping strong-refs to it to avoid the allocator (along its provided memory pool) being deleted too early. I also replaced the qDebug usage with printfs because I got similar crashes at shutdown. Greets -- Kevin Funk

Re: Review Request 114715: Attempt to fix KZoneAllocator issue

2014-01-27 Thread Kevin Funk
kdecore/util/kallocator.cpp 8b21120c62c513ea41686fe8185ec2808fe5d83a kdeui/util/kcompletion.cpp 340aa92b900d670e2ad73f70a63d5221d0feed1d kdeui/util/kcompletion_p.h 1cf31db3f16fe3421415cd54265eee20bb998710 Diff: https://git.reviewboard.kde.org/r/114715/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 114715: Attempt to fix KZoneAllocator issue

2014-01-26 Thread Kevin Funk
it: https://git.reviewboard.kde.org/r/114715/#review48232 ------- On Jan. 3, 2014, 5:52 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Coding style: block braces in switch cases

2014-01-13 Thread Kevin Funk
e improved readability of the code this indentation scheme encourages is worth it. (All 'break' statements in one column, less "jumping" of your eye focus). In any case, the '{' and '}' "inside" a case label is syntactic sugar anyway, so it shou

Re: Review Request 114715: Attempt to fix KZoneAllocator issue

2014-01-03 Thread Kevin Funk
d83a kdeui/util/kcompletion.cpp 340aa92b900d670e2ad73f70a63d5221d0feed1d kdeui/util/kcompletion_p.h 1cf31db3f16fe3421415cd54265eee20bb998710 Diff: https://git.reviewboard.kde.org/r/114715/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 113858: Add .reviewboardrc

2013-11-28 Thread Kevin Funk
marked as submitted. Review request for kdelibs. Repository: kdelibs Description --- Add .reviewboardrc Diffs - .reviewboardrc PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113858/diff/ Testing --- Thanks, Kevin Funk

Review Request 113954: Remove dead code related to kompare support

2013-11-19 Thread Kevin Funk
http://git.reviewboard.kde.org/r/113954/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 113857: Get rid off ifdefs for windows driver kit

2013-11-19 Thread Kevin Funk
ce6c2c45338edbe470ba8f040dd3a3e829073d9c solid/solid/backends/win/winopticaldrive.cpp fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e Diff: http://git.reviewboard.kde.org/r/113857/diff/ Testing --- Thanks, Kevin Funk

Review Request 113858: Add .reviewboardrc

2013-11-14 Thread Kevin Funk
--- Add .reviewboardrc Diffs - .reviewboardrc PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113858/diff/ Testing --- Thanks, Kevin Funk

Review Request 113857: Get rid off ifdefs for windows driver kit

2013-11-14 Thread Kevin Funk
fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e Diff: http://git.reviewboard.kde.org/r/113857/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Kevin Funk
/tests/CMakeLists.txt f19e563d5d99ad2f2806140c5b21e38b20dbde0d kdecore/tests/kcompositejobtest.h PRE-CREATION kdecore/tests/kcompositejobtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/108770/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Kevin Funk
ob.cpp 5ddabd71e5bbb5f0a555a201223a52950b85e786 kdecore/tests/CMakeLists.txt f19e563d5d99ad2f2806140c5b21e38b20dbde0d kdecore/tests/kcompositejobtest.h PRE-CREATION kdecore/tests/kcompositejobtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/108770/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-05 Thread Kevin Funk
/tests/kcompositejobtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/108770/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-05 Thread Kevin Funk
ob.cpp 5ddabd71e5bbb5f0a555a201223a52950b85e786 kdecore/jobs/kcompositejob_p.h bef06e9bff532b45a8d66380a65117737275be9e Diff: http://git.reviewboard.kde.org/r/108770/diff/ Testing --- Thanks, Kevin Funk

Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-04 Thread Kevin Funk
Diff: http://git.reviewboard.kde.org/r/108770/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request: make folderview compile with Qt 4.7

2012-02-20 Thread Kevin Funk
ther use a boolean variable indicating that the item was found, then doing if (!success) {...} after the for loop. Avoid "return" statements in deeply nested code (hard to debug). - Kevin Funk On Feb. 20, 2012, 5:18 p