Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Kirill Elagin
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kir

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Kirill Elagin
> On March 29, 2014, 8:39 p.m., Kirill Elagin wrote: > > Why not simply add a parameter to KApplication constructor? > > Thomas Lübking wrote: > Being? > I'm not aware of such parameter, kdelibs is semi-frozen and the > requirement is also pretty s

Re: Review Request 117166: remove /MainApplication object from screenlocker greeter interface

2014-03-29 Thread Kirill Elagin
? - Kirill Elagin On March 29, 2014, 8:32 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kir

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kir

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
On March 29, 2014, 11:58 a.m., Kirill Elagin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117157/ > ---

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
----- On March 29, 2014, 11:58 a.m., Kirill Elagin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117157/ > ---

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
/ Testing (updated) --- I've tested this with KDE 4.11.5 which I'm currently running. Rebasing to master was completely trivial; I've looked through the code and I believe all the assumptions I made are still valid in master. Thanks, Kirill Elagin

Review Request 117157: Unlock session via DBus

2014-03-29 Thread Kirill Elagin
/ksmserver/screenlocker/ksldapp.h b292b62f4df073fff31bcbfd0e39f4c4fe04c92d plasma-workspace/ksmserver/screenlocker/ksldapp.cpp f2e5262524447e8ae1df1fbf6543297c3be3e6b8 Diff: https://git.reviewboard.kde.org/r/117157/diff/ Testing --- Thanks, Kirill Elagin