Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Nick Shaforostoff
aries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Nick Shaforostoff
ard.kde.org/r/122320/#review75358 --- On Фев. 4, 2015, 12:31 д.п., Nick Shaforostoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-03 Thread Nick Shaforostoff
kde/kcminit/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-03 Thread Nick Shaforostoff
't be happy with that > > change ;-) > > > > you need to do something like: > > if (XCB_XCB_FOUND) > > target_link_libraries(kdeinit_kcminit XCB::XCB) > > endif() > > Nick Shaforostoff wrote: > it compiles even if i remove fin

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-03 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75256 --- On Лют. 2, 2015, 9:15 після полудня, Nick Shaforostoff wrote: > > -

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-02 Thread Nick Shaforostoff
ng --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-01-31 Thread Nick Shaforostoff
es and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-01-29 Thread Nick Shaforostoff
sts.txt b17951f startkde/kcminit/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
m as if you had introduced it, the > "QGuiApplication::screens().count() > 1" check is, as has been pointed out in > this review several times, still wrong for sure. > Do you intend to keep working on this code? (to get rid of > QGuiApplication and perhaps the ini read)

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74982 --- On Січ. 29, 2015, 11:58 до полудня, Nick Shaforostoff wrote: > > --- > This is an automatica

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
;kcminit --list' and kcminit AAA Thanks, Nick Shaforostoff

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
t --list' and kcminit AAA Thanks, Nick Shaforostoff

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
X11 > > multi-head, it should open an xcb_connection_t - if that fails we don't > > have an X-Server. If it succeeds we can check the number of screens. > > Nick Shaforostoff wrote: > understood, but the question remains: is kcminit the best place to do > multihe

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
X11 > > multi-head, it should open an xcb_connection_t - if that fails we don't > > have an X-Server. If it succeeds we can check the number of screens. > > Nick Shaforostoff wrote: > understood, but the question remains: is kcminit the best place to do > multihe

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
X11 > > multi-head, it should open an xcb_connection_t - if that fails we don't > > have an X-Server. If it succeeds we can check the number of screens. > > Nick Shaforostoff wrote: > understood, but the question remains: is kcminit the best place to do > multihe

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
X11 > > multi-head, it should open an xcb_connection_t - if that fails we don't > > have an X-Server. If it succeeds we can check the number of screens. > > Nick Shaforostoff wrote: > understood, but the question remains: is kcminit the best place to do > multihe

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
ing against QtGui Diffs (updated) - startkde/kcminit/CMakeLists.txt ffae38c startkde/kcminit/main.h 1140b77 startkde/kcminit/main.cpp 4724323 Diff: https://git.reviewboard.kde.org/r/122270/diff/ Testing --- compiled, ran 'kcminit --list' and kcminit AAA

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74806 --- On Січ. 27, 2015, 3:10 до полудня, Nick Shaforostoff wrote: > >

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Nick Shaforostoff
for it. http://www.kde-forum.org/artikel/16920/kde-multihead-environment-variable.html we still can avoid qtgui linkage and possibli ini file read by adding a cmdline option or generally move KDE_MULTIHEAD setup to another place (close to it's users?) - Nick Shaforostoff On Jan. 27, 2015,

Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Nick Shaforostoff
kde/kcminit/CMakeLists.txt ffae38c startkde/kcminit/main.h 1140b77 startkde/kcminit/main.cpp 4724323 Diff: https://git.reviewboard.kde.org/r/122270/diff/ Testing --- compiled, ran 'kcminit --list' and kcminit AAA Thanks, Nick Shaforostoff

Review Request: make Speller::spellCheckerFound() return true when the dict for the current language is found (important when there was no dict for default language)

2012-01-18 Thread Nick Shaforostoff
This addresses bug 256896. http://bugs.kde.org/show_bug.cgi?id=256896 Diffs - kdeui/sonnet/highlighter.cpp 3f478f0 Diff: http://git.reviewboard.kde.org/r/103729/diff/diff Testing --- Thanks, Nick Shaforostoff

Re: Review Request: check if enough disk space available before even starting to copy each file

2011-12-16 Thread Nick Shaforostoff
Testing --- files get copied fine. if i copy a bunch of files including one big file (created with dd if=/dev/zero of=file.out bs=1MB count=300), then the copying process stops when it gets to this big file (i have small disk on my virtual machine, only 400 mb free) Thanks, Nick

Review Request: check if enough disk space available before even starting to copy each file

2011-12-14 Thread Nick Shaforostoff
when it gets to this big file (i have small disk on my virtual machine, only 400 mb free) Thanks, Nick Shaforostoff

KRandomSequence and 64-bit

2011-12-09 Thread Nick Shaforostoff
Hi all. I see that KRandomSequence uses longs everywhere. long on 64-bit gcc systems is 8 bytes long, while int is always 4. maybe this is ok overall, but e.g. it uses KRandom::random() return value inside, which is int. so i suppose this can actually make the sequence less random. i propose

Re: Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
> On Dec. 6, 2011, 5:58 p.m., Nick Shaforostoff wrote: > > I have an account called shaforo. i could push to kdepimlibs with it, but i > > couldn't push to kdelibs. is it because of lack of permissions? > > Alexander Potashev wrote: > You need to clo

Re: Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
with it, but i couldn't push to kdelibs. is it because of lack of permissions? - Nick Shaforostoff On Dec. 6, 2011, 5:53 p.m., Nick Shaforostoff wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
/103348/diff/diff Testing --- kwrite starts fine with the new kdeui lib Thanks, Nick Shaforostoff

Re: Review Request: Make DBusMenuQt optional

2011-02-26 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4898/#review9913 --- Ship it! what's the status of this patch for KDE 4.6? it makes c