Re: Review Request: Speed limit in ftp kio slave

2011-08-21 Thread Nicolas Alvarez
> On Aug. 10, 2011, 1:07 p.m., David Faure wrote: > > kioslave/ftp/speedController.h, line 24 > > > > > > kde_file.h isn't used in this header -> move the #include to the .cpp > > file. > > Tushar Mehta wrote: >

Re: kdeutils has migrated to git

2011-08-20 Thread Nicolas Alvarez
Aaron J. Seigo wrote: > On Saturday, August 20, 2011 16:48:09 Raphael Kubo da Costa wrote: >> For now, I have created a scratch git repository with the files which >> used to be in the top-level kdeutils directory in SVN, so you can just >> use the CMakeLists.txt there to build everything (there ar

Re: How to see the resolution of merge of KDE/4.7 into KF5

2011-08-20 Thread Nicolas Alvarez
Stephen Kelly wrote: > I couldn't make git show me the conflicts. I tried git show, which > surprises me as it shows a 3 way diff of a single file which was > apparently not in conflict (full output at > http://steveire.com/mergecommit). I also tried several variations of git > diff frameworks^...o

Re: My Plans, Your Plans: Berlin Desktop Summit

2011-07-30 Thread Nicolas Alvarez
Alex Fiestas wrote: > · Draft a plan for colord integration (next thing after krandr is fixed) That better be optional at runtime :) There aren't that many people who care about color profiles (but we really need the functionality for those who do). > · Draft a plan for systemd kde-workspace int

Re: My Plans, Your Plans: Berlin Desktop Summit

2011-07-27 Thread Nicolas Alvarez
Sebastian Kügler wrote: > One of my goals is to take steps to make the release team more scalable, > and reduce its bus numbers. Surely you mean increase :) A bus number of 1 means the team has a single point of failure. -- Nicolas

Re: Review Request: Fix logic with clear-button animation in klineedit (notably at first try) and address bug 268898.

2011-07-27 Thread Nicolas Alvarez
> On July 26, 2011, 10:46 p.m., Aleix Pol Gonzalez wrote: > > kdeui/widgets/klineedit.cpp, line 358 > > > > > > Wouldn't it be better to put it this way? Just saying... > > > > d->clearButton->animateVisibl

Re: Formal complaint concerning the use of the name "System Settings" by GNOME

2011-07-25 Thread Nicolas Alvarez
David Jarvie wrote: > On Mon, July 25, 2011 12:50 pm, Ambroz Bizjak wrote: >> Hi Mark, >> have you seen my proposed improvement on your suggestion? >> >> http://lists.kde.org/?l=kde-core-devel&m=131149560119520&w=2 >> >> I suggest that you consider it, because it would avoid having to >> update the

Re: Fixes in Git (first in stable, then merge to master)

2011-07-23 Thread Nicolas Alvarez
Nicolas Alvarez wrote: > - Figure out how to solve the scripty problem. scripty does its own > conflicting commits to .desktop files in both branches, and that won't > change[1]. We probably need a custom merge tool for .desktop-like files > that ignores translations. I *think* I

Re: Fixes in Git (first in stable, then merge to master)

2011-07-22 Thread Nicolas Alvarez
David Jarvie wrote: > On Saturday 23 July 2011 00:00:16 Nicolas Alvarez wrote: > During the stable branch freeze before a minor version release (such as > currently before the 4.7 release), it isn't possible to commit bug fixes > to stable first and then merge to master. O

Re: Fixes in Git (first in stable, then merge to master)

2011-07-22 Thread Nicolas Alvarez
Alex Fiestas wrote: > Last few days I have been patching some pieces of our workspace here and > there, the first set of patches I did them directly into master which if > I remember correctly was against the policy. > So, the second round of fixes I tried to do it the right way, which is: > 1-Crea

Re: Review Request: Locale-independent parsing of floats in trader queries

2011-07-10 Thread Nicolas Alvarez
> On July 10, 2011, 11:27 p.m., Nicolas Alvarez wrote: > > okay... reviewboard ate my message. Trying again: Note that flex (.l) files are used to generate C/C++ source code, but that's *not* being done at build time. You'll have to manually update lex.c when committi

Re: Review Request: Locale-independent parsing of floats in trader queries

2011-07-10 Thread Nicolas Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101610/#review4582 --- - Nicolas On July 10, 2011, 7:39 a.m., Chusslove Illich wrote:

KConfigIniBackend::isWritable bug

2011-06-07 Thread Nicolas Alvarez
Hi, I'm trying to get kdelibs unit tests to run in a clean and headless environment (for automated testing). I'm starting an X server, dbus, and kdeinit by hand. Currently kded (started by kdeinit) is failing to start up if I'm running it for the first time and there is currently no ~/.kde dir

Re: Releases of the thing that was KDE

2011-06-06 Thread Nicolas Alvarez
Scott Kitterman wrote: > New thread as requested. > > I've been told on IRC that we will still have an integrated release of > what used to be KDE (I've no clue what to call it now since I think I read > KDE SC was deprecated). > > All I see in the messaging from the platform sprint seems to be a

Re: Objections to stop creating nightly tarballs from svn?

2011-05-21 Thread Nicolas Alvarez
Michael Pyne wrote: > Perhaps this is ironic, but kdesrc-build does *not* at this point support > snapshots for git modules (even hosted on git.kde.org) because I assume > (and this is just my assumption) that the cost of generating the snapshot > would be a net loss for the git.kde.org server. Th

Re: Review Request: Deprecate KLineEdit::clickMessage

2011-05-13 Thread Nicolas Alvarez
> On May 14, 2011, 4:01 a.m., Shaun Reich wrote: > > Are you sure the behaviour for the Qt method 100% equivalent to the > > current? I ask this because now that the deprecated method forwards to it, > > naturally it's quite important to make sure nothing gets fscked up. Someone in #kde-devel

Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Nicolas Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/ --- (Updated May 2, 2011, 9:34 p.m.) Review request for kdelibs. Changes ---

Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Nicolas Alvarez
n automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/#review3076 ----------- On May 2, 2011, 7:26 p.m., Nicolas Alvarez wrote: > > --- > This is an automatically gener

Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-05-02 Thread Nicolas Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/ --- Review request for kdelibs. Summary --- kdelibs compilation is broken

Re: Initial merge (was: Re: Merge or Cherry-Pick?)

2011-02-04 Thread Nicolas Alvarez
Thiago Macieira wrote: > On Friday, 4 de February de 2011 15:18:58 Nicolas Alvarez wrote: >> Johannes Sixt wrote: >> > (1) All back- and forward-porting was complete when SVN went >> > read-only. >> >> IMHO this is not a safe assumption. As I said befor

Re: Initial merge (was: Re: Merge or Cherry-Pick?)

2011-02-04 Thread Nicolas Alvarez
Johannes Sixt wrote: > Am 2/3/2011 13:04, schrieb Johannes Sixt: >> Before anybody begins to work in this way, someone with sufficient >> knowlege must introduce the first real merge of the 4.6 branch into the >> master branch. The conflicts must be resolved; or it is possible to punt >> by using -

Re: Merge or Cherry-Pick?

2011-02-03 Thread Nicolas Alvarez
Johannes Sixt wrote: > Am 2/3/2011 12:15, schrieb Hugo Pereira Da Costa: >> So I git cloned KDE/4.6 into some local branch (git checkout KDE/4.6; git >> checkout -b toolbuttons), then fix, then test. >> >> Now I want to merge to the KDE/4.6 branch; thats easy. >> >> Then I want to merge to master

Re: kdelibs, kdebase moving to Git this Saturday

2011-01-29 Thread Nicolas Alvarez
Torgny Nyblom wrote: > On Friday 28 January 2011 16.13.31 Nicolas Alvarez wrote: >> The kdebase-runtime repository is currently 260MB, and kdebase-workspace >> is 300MB. Apparently it's because of wallpapers and icons, either in the >> current revision or in the past.

Re: kdelibs, kdebase moving to Git this Saturday

2011-01-29 Thread Nicolas Alvarez
Nicolás Alvarez wrote: > Ian Monroe wrote: >> git://anongit.kde.org/scratch/nalvarez/kdelibs-convtest >> git://anongit.kde.org/scratch/ianmonroe/kdebase-apps >> git://anongit.kde.org/scratch/ianmonroe/kdebase-runtime >> git://anongit.kde.org/scratch/ianmonroe/kdebase-workspace >> git://anongit.kde.

Re: kdelibs, kdebase moving to Git this Saturday

2011-01-28 Thread Nicolas Alvarez
Ian Monroe wrote: > For up to one week if someone finds a major problem in the history a > re-push will be considered. After that we'll just live with it. > > ...but far better would be for any problem to be found now. Please > note that the repo names are not the final ones (they will be konsole,

Re: kdelibs, kdebase moving to Git this Saturday

2011-01-28 Thread Nicolas Alvarez
John Tapsell wrote: > 2011/1/27 Nicolás Alvarez : >> Please, help review the repositories before migration! Unlike KDE >> software, here we won't have point releases to fix bugs later :) > > I have quite a few commits in kdebase-workspace with the commit message: > > SVN_SILENT: > Do blahblah >