Re: Review Request: Add the resource paramater in resource queries

2012-12-11 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102283/#review23303 --- Ship it! Ship It! - Sebastian Trueg On Aug. 10, 2011, 3:22

Re: Review Request: Make nepomuk runner remove undesired matches

2012-04-16 Thread Sebastian Trueg
On April 15, 2012, 5:21 p.m., Sebastian Trueg wrote: This is actually a bug that needs to be addressed differently. Your solution is simply a hack. Normally Nepomuk should not return those results at all. The question is though: why does it? Only if we figure that out we can fix

Re: Review Request: Make nepomuk runner remove undesired matches

2012-04-15 Thread Sebastian Trueg
. Your solution is simply a hack. Normally Nepomuk should not return those results at all. The question is though: why does it? Only if we figure that out we can fix it properly. - Sebastian Trueg On April 9, 2012, 10:29 p.m., Lamarque Vieira Souza wrote

Re: Review Request: Better stars rating in dolphin

2012-04-04 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104479/#review12155 --- Ship it! Ship It! - Sebastian Trueg On April 4, 2012, 5:10

Re: Review Request: Better stars rating in dolphin

2012-04-03 Thread Sebastian Trueg
/widgets/kratingwidget.cpp http://git.reviewboard.kde.org/r/104479/#comment9568 Please fix the indentation according to kdelibs policy. kdeui/widgets/kratingwidget.cpp http://git.reviewboard.kde.org/r/104479/#comment9569 Pedantic: please use whitespace correctly. - Sebastian Trueg

Re: Review Request: Better stars rating in dolphin

2012-04-03 Thread Sebastian Trueg
http://git.reviewboard.kde.org/r/104479/#comment9572 Indentation should be 4 spaces. - Sebastian Trueg On April 3, 2012, 6:44 p.m., Anant Kamath wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-08 Thread Sebastian Trueg
. Thumbnails for everything else still working fine. Thanks, Sebastian Trueg

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-08 Thread Sebastian Trueg
., Sebastian Trueg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/ --- (Updated Feb. 8, 2012, 9:56 p.m.) Review request

Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-07 Thread Sebastian Trueg
my mime-type. Diffs - kio/kio/previewjob.cpp 5635875 Diff: http://git.reviewboard.kde.org/r/103882/diff/diff Testing --- Tested on my custom KIO slave: perfect thumbnails. Thumbnails for everything else still working fine. Thanks, Sebastian Trueg

Re: Review Request: Fix compilation error in nepomuk kioslave

2011-12-03 Thread Sebastian Trueg
://git.reviewboard.kde.org/r/103312/#comment7312 This does not make any sense. Nepomuk/Resource simply includes nepomuk/resource.h. Could it be that you tried compiling nepomuk-core? - Sebastian Trueg On Dec. 3, 2011, 4:42 a.m., Romário Rios wrote

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103300/#review8638 --- Ship it! Ship It! - Sebastian Trueg On Nov. 30, 2011, 9:17

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Sebastian Trueg
On Nov. 30, 2011, 9:30 p.m., Sebastian Trueg wrote: kio/kfile/kfilemetadatareaderprocess.cpp, line 170 http://git.reviewboard.kde.org/r/103300/diff/1/?file=42530#file42530line170 Why do you need to load the kio4 catalog? Xuetian Weng wrote: Emm.. I'm not very sure

Re: Review Request: Fix Date Display in dolphin info panel

2011-11-30 Thread Sebastian Trueg
://git.reviewboard.kde.org/r/103300/#comment7294 Why do you need to load the kio4 catalog? - Sebastian Trueg On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: nepomuk/services/storage/datamanagementmodel.h fix to allow compiling on apple's gcc 4.2.1

2011-10-05 Thread Sebastian Trueg
to define a typedef instead. In any case make sure you backport to the KDE/4.7 branch and also fix it in nepomuk-core. - Sebastian Trueg On Oct. 2, 2011, 2:13 p.m., Kurt Hindenburg wrote: --- This is an automatically generated e-mail

Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

2011-09-06 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102523/#review6294 --- The weird thing here is that this widget can also be opened

Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

2011-09-03 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102523/#review6253 --- Please add nepomuk as review group. :) - Sebastian On Sept.

Re: Review Request: Add the resource paramater in resource queries

2011-08-11 Thread Sebastian Trueg
On Wednesday 10 August 2011 15:22:51 Vishesh Handa wrote: If I push it into the 'frameworks' branch, then it won't be a part of KDE until KDE Platform 5, which is quite far away. Yes, this is why we were talking about splitting out nepomuk into its own repo, since it's already separate.

Re: Review Request: Add the resource paramater in resource queries

2011-08-10 Thread Sebastian Trueg
. 10, 2011, 2:15 p.m.) Review request for kdelibs, Nepomuk and Sebastian Trueg. Summary --- Add a resource=nepomuk:/res/some-uuid in the query url. This allows us to use the resource uri to set a custom image while displaying results. What am I supposed to do with this? Master

Re: Review Request: Remove monthly auto backups from the GUI

2011-08-04 Thread Sebastian Trueg
/ --- (Updated Aug. 3, 2011, 1:47 p.m.) Review request for KDE Runtime and Sebastian Trueg. Summary --- Monthly auto backup was removed in 4.6 with http://websvn.kde.org/?view=revisionrevision=1215783 with this log: Removed monthly auto backups in 4.6. It was missing

Re: Review Request: Transparent QListQUrl handling in KUrl::List

2011-06-22 Thread Sebastian Trueg
://git.reviewboard.kde.org/r/101702/#review4073 --- On June 20, 2011, 11:58 a.m., Sebastian Trueg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org

Re: Review Request: fix broken nepomuk ui files to make messages translatable

2011-04-14 Thread Sebastian Trueg
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/ --- (Updated April 13, 2011, 2:04 p.m.) Review request for KDE Runtime and Sebastian Trueg. Summary --- Some nepomuk ui files

Re: KIO design decision necessary: unique names in KIO listings

2011-01-15 Thread Sebastian Trueg
On 01/14/2011 11:28 PM, David Faure wrote: On Friday 14 January 2011, Sebastian Trueg wrote: Hi guys, the problem is fairly simple: KIO relies on entry names to be unique. That makes sense since there needs to be some way to identify the items in a dir listing. This also worked nicely in pre

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-14 Thread Sebastian Trueg
However, the query parser still uses static QRegExp objects which seems a bad idea, isn't that right? Thus, I suppose it would be better to wrap them in a mutex'ed object and create that via K_GLOBAL_STATIC? Cheers, Sebastian On 01/14/2011 01:17 AM, Thiago Macieira wrote: On Thursday, 13 de

KIO design decision necessary: unique names in KIO listings

2011-01-14 Thread Sebastian Trueg
Hi guys, the problem is fairly simple: KIO relies on entry names to be unique. That makes sense since there needs to be some way to identify the items in a dir listing. This also worked nicely in pre-Nepomuk days. However, with the introduction of desktop search the filename is no unique

Review Request: Use UDS_NAME as a fallback when sorting via UDS_DISPLAY_NAME

2011-01-10 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6322/ --- Review request for kdelibs and Peter Penz. Summary --- When sorting by