Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-13 Thread Ralf Jung
Hi, > First, sorry I confused kdelibs with kde-baseapps in this response. So > forget what I said about changes being merged back into 4.10 branch by > David. Anyhow, I have now attempted to fix this issue as reported here. See > > http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2ed

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-13 Thread Dawit A
On Thu, Sep 13, 2012 at 11:39 AM, Ralf Jung wrote: > Hi, > > > First, sorry I confused kdelibs with kde-baseapps in this response. So > > forget what I said about changes being merged back into 4.10 branch by > > David. Anyhow, I have now attempted to fix this issue as reported here. > See > > >

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-12 Thread Dawit A
On Wed, Sep 12, 2012 at 2:50 PM, Allen Winter wrote: > On Wednesday 12 September 2012 08:12:58 PM Thomas Lübking wrote: > > Am 12.09.2012, 20:04 Uhr, schrieb Dawit A : > > > > > Qt's moc processor does not > > > seem to correctly handle #if macros. > > > > *sigh* "not at all" is more like it. **G

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-12 Thread Allen Winter
On Wednesday 12 September 2012 08:12:58 PM Thomas Lübking wrote: > Am 12.09.2012, 20:04 Uhr, schrieb Dawit A : > > > Qt's moc processor does not > > seem to correctly handle #if macros. > > *sigh* "not at all" is more like it. **GREATSIGH*** > > You'll have to move the class into an extra header

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-12 Thread Thomas Lübking
Am 12.09.2012, 20:04 Uhr, schrieb Dawit A : Qt's moc processor does not seem to correctly handle #if macros. *sigh* "not at all" is more like it. **GREATSIGH*** You'll have to move the class into an extra header and make it's inclusion and moc invocation (latter in cmake) optional. D

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-12 Thread Dawit A
On Tue, Sep 11, 2012 at 9:05 AM, Dawit A wrote: > > > On Tue, Sep 11, 2012 at 6:22 AM, Ben Cooksley wrote: > >> Hi Dawit, >> >> It has come to my attention that since commit >> 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the >> build for it has been broken. >> This is due to

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-11 Thread Dawit A
On Tue, Sep 11, 2012 at 6:22 AM, Ben Cooksley wrote: > Hi Dawit, > > It has come to my attention that since commit > 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the > build for it has been broken. > This is due to it depending on new features, present only in the KDE/4.9 > br

Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-11 Thread Ben Cooksley
Hi Dawit, It has come to my attention that since commit 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the build for it has been broken. This is due to it depending on new features, present only in the KDE/4.9 branch. This is problematic because: - kde-baseapps depends upon a mi