Re: Croutons in kdereview

2021-10-27 Thread Kevin Ottens
Hello, I don't think Jonah's question got an answer. If it did somehow it didn't show up in my mail client and my apologies in advance. :-) In any case I've been wondering exactly the same thing. I'm asking because the fate of libraries like QCoro and Croutons would be to end up in KDE Framewor

Re: Croutons in kdereview

2021-10-27 Thread Jonathan Riddell
Looks good, I've now packaged this for KDE neon unstable edition https://build.neon.kde.org/view/3%20unstable%20%E2%98%A3%20git%20master/job/focal_unstable_neon-packaging_croutons/ Jonathan On Sun, 29 Aug 2021 at 10:25, Janet Blackquill wrote: > Hello, > > https://invent.kde.org/libraries/cro

Re: Croutons in kdereview

2021-10-24 Thread Janet Blackquill
Wll, I don't see any response to this, and I don't consider it that important for an inital release, so guess I'll mark an initial one, and maybe we can add this in later. -- Janet Am Mi., 13. Okt. 2021 um 23:25 Uhr schrieb Janet Blackquill : > > I don't think that would work, considering tha

Re: Croutons in kdereview

2021-10-14 Thread Janet Blackquill
I don't think that would work, considering that for practicality reasons, we need a std::function to hold onto the then callback to be able to invoke it when the future completes. Also, lambdas capturing unique_ptrs seem to be somewhat rare. Not sure that it is worth taking time to pursue a non-cop

Re: Croutons in kdereview

2021-08-30 Thread Ivan Čukić
> > `then` when calling it, which you lose if you switch from std::function to > > a generic Fn parameter. But you can (since you're already using C++20) > > restrict it with the std::invocable concept to avoid this loss of API > > usage information. > > I still don't follow what this means for Cr

Re: Croutons in kdereview

2021-08-30 Thread Jonah Brüchert
Hi Janet, I know I have asked this earlier already, but what is the relationship between your library and QCoro? Especially now that we are starting to use QCoro in some KDE projects (namely spacebar and plasma-dialer), it would be really unfortunate if they are not compatible. The scope o

Re: Croutons in kdereview

2021-08-30 Thread Ivan Čukić
Hi Janet, > Addressed most of your feedback besides the std::expected thing Great! > rather wait and see what that ends up being like once in an actual C++ > standard and use before modelling Result to be more like it. Fair enough, though it is not expected that the proposal will change much in

Re: Croutons in kdereview

2021-08-29 Thread Ben Cooksley
On Mon, Aug 30, 2021 at 10:00 AM Albert Astals Cid wrote: > El diumenge, 29 d’agost de 2021, a les 23:30:23 (CEST), Janet Blackquill > va escriure: > > They're there for the CamelCase headers generating macro, which > > doesn't seem to understand snake_case.h headers. > > Have you tried fixing th

Re: Croutons in kdereview

2021-08-29 Thread Albert Astals Cid
El diumenge, 29 d’agost de 2021, a les 23:30:23 (CEST), Janet Blackquill va escriure: > They're there for the CamelCase headers generating macro, which > doesn't seem to understand snake_case.h headers. Have you tried fixing that in ECM? Do git+symlinks even work on windows? Or we don't care for

Re: Croutons in kdereview

2021-08-29 Thread Albert Astals Cid
El diumenge, 29 d’agost de 2021, a les 5:10:04 (CEST), Janet Blackquill va escriure: > Hello, > > https://invent.kde.org/libraries/croutons is in kdereview now > > Croutons is a library containing assorted functionality for dealing > with asynchronous code in Qt, most notably a future type that

Re: Croutons in kdereview

2021-08-29 Thread Ivan Čukić
Hi, Cool to have a library like this. I have a few nit-picks. I'd put the whole library in a namespace as it uses some quite common names like Result, Error and Future. future.h:15 The Result type could be made more API-compatible with the expected std::expected. Things like explicit operato

Croutons in kdereview

2021-08-29 Thread Janet Blackquill
Hello, https://invent.kde.org/libraries/croutons is in kdereview now Croutons is a library containing assorted functionality for dealing with asynchronous code in Qt, most notably a future type that can be passed into QML as a JavaScript Thennable (similarly to Qt IVI's PendingReply) and headers