Thanks for the feedback so far!
This has now exceeded the 2 weeks period, the only unaddressed feedback
(unless I missed something else) is the one from Sandro about having a release
before being able to pass kdereview. Ben's input on this however seems to
confirm my understanding that this is
Hi,
> KDE Itinerary has been moved to kdereview:
>
> Code: https://invent.kde.org/kde/itinerary
> Workboard: https://phabricator.kde.org/project/board/280/query/all/
>
> KDE Itinerary is a Kirigami-based mobile application for managing your
> itinerary as a timeline, including access to your tra
On Sat, Dec 21, 2019 at 7:59 PM Volker Krause wrote:
>
> On Friday, 20 December 2019 22:50:54 CET Sandro Knauß wrote:
> > Hi,
> >
> > > KDE Itinerary has been moved to kdereview:
> > >
> > > Code: https://invent.kde.org/kde/itinerary
> > > Workboard: https://phabricator.kde.org/project/board/280/q
On Friday, 20 December 2019 22:50:54 CET Sandro Knauß wrote:
> Hi,
>
> > KDE Itinerary has been moved to kdereview:
> >
> > Code: https://invent.kde.org/kde/itinerary
> > Workboard: https://phabricator.kde.org/project/board/280/query/all/
> >
> > KDE Itinerary is a Kirigami-based mobile applicat
Hey,
On dimanche 8 décembre 2019 13:14:43 CET Volker Krause wrote:
> Hi,
>
> KDE Itinerary has been moved to kdereview:
>
> Code: https://invent.kde.org/kde/itinerary
> Workboard: https://phabricator.kde.org/project/board/280/query/all/
>
COPYING.LIB contains the LGPL 2.1 license. The files in
On Monday, 9 December 2019 11:33:43 CET Jonathan Riddell wrote:
> Looking good
>
> It's more common to name COPYING as COPYING.LIB when it is the LGPL
>
> In the appdata file org.kde.itinerary.desktop it's better to use
> an id without the .desktop on the end since that's unnecessary
>
> And it
On Sunday, 8 December 2019 14:07:57 CET Christophe Giboudeaux wrote:
> Hey,
>
> On dimanche 8 décembre 2019 13:14:43 CET Volker Krause wrote:
> > Hi,
> >
> > KDE Itinerary has been moved to kdereview:
> >
> > Code: https://invent.kde.org/kde/itinerary
> > Workboard: https://phabricator.kde.org/p
Looking good
It's more common to name COPYING as COPYING.LIB when it is the LGPL
In the appdata file org.kde.itinerary.desktop it's better to use
an id without the .desktop on the end since that's unnecessary
And it's missing the launchpable tag
org.kde.$NAME.desktop recommended, see
https://w
Hi,
KDE Itinerary has been moved to kdereview:
Code: https://invent.kde.org/kde/itinerary
Workboard: https://phabricator.kde.org/project/board/280/query/all/
KDE Itinerary is a Kirigami-based mobile application for managing your
itinerary as a timeline, including access to your travel documents
