[DONE] Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-29 Thread Friedrich W. H. Kossebau
Hi, Am Samstag, 15. August 2020, 19:20:53 CEST schrieb Friedrich W. H. Kossebau: > what is markdownpart you ask? A KParts plugin allowing to view markdown > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or > Konqueror, being mainly a wrapper around QTextDocument::setMarkdown & >

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-23 Thread Friedrich W. H. Kossebau
Am Samstag, 15. August 2020, 19:20:53 CEST schrieb Friedrich W. H. Kossebau: > Note: for now Qt 5.15-only, 5.14 possible but untested. BTW, thanks to feedback the min dependencies are now lowered to Qt 5.14 & KF 5.66. > I would like to propose markdownpart for a move into community maintenance >

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-23 Thread Friedrich W. H. Kossebau
Am Freitag, 21. August 2020, 23:34:03 CEST schrieb Albert Astals Cid: > El dilluns, 17 d’agost de 2020, a les 23:04:44 CEST, Friedrich W. H. Kossebau va escriure: > > But not my call, after all I offer this to KDE community for adoption, sou > > your choice. > > I'm a bit concerned about this bei

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-21 Thread Albert Astals Cid
El dilluns, 17 d’agost de 2020, a les 23:04:44 CEST, Friedrich W. H. Kossebau va escriure: > But not my call, after all I offer this to KDE community for adoption, sou > your choice. I'm a bit concerned about this being "abandonware" from birth, but seems there's relative interest from the comm

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-19 Thread Kevin Kofler
Ivan Čukić wrote: > markdownpartfactory.cpp:45 > > Personal preference - use `auto` when you have `= new Something(:::)` on > the right - no need for `Something` to be written twice: > Something* p = new Something(...) > > The variable part can even go away - just return new MarkdownPart. >

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-18 Thread Elvis Angelaccio
On 15/08/20 19:20, Friedrich W. H. Kossebau wrote: > Hi, > > what is markdownpart you ask? A KParts plugin allowing to view markdown > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or Konqueror, > being mainly a wrapper around QTextDocument::setMarkdown & QTextBrowser. > See

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-18 Thread Elvis Angelaccio
On 17/08/20 23:04, Friedrich W. H. Kossebau wrote: > Hi Elvis, > > Am Montag, 17. August 2020, 22:43:37 CEST schrieb Elvis Angelaccio: >> On 15/08/20 19:20, Friedrich W. H. Kossebau wrote: >>> Hi, >>> >>> what is markdownpart you ask? A KParts plugin allowing to view markdown >>> documents rend

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-17 Thread Friedrich W. H. Kossebau
Hi Elvis, Am Montag, 17. August 2020, 22:43:37 CEST schrieb Elvis Angelaccio: > On 15/08/20 19:20, Friedrich W. H. Kossebau wrote: > > Hi, > > > > what is markdownpart you ask? A KParts plugin allowing to view markdown > > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or > > Kon

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-16 Thread Friedrich W. H. Kossebau
Hi Ivan, Am Sonntag, 16. August 2020, 17:00:23 CEST schrieb Ivan Čukić: > Hi Friedrich, > > Very nice, thanks for doing this! Glad to see people liking it, so my time was more worth it :) And thank you for review. > These are the few nit-picks (feel free to ignore them) I have: Nitpicks are w

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-16 Thread Ivan Čukić
Hi Friedrich, Very nice, thanks for doing this! These are the few nit-picks (feel free to ignore them) I have: markdownview.cpp:55 The `hasSelection` variable makes the code look much more complex than it is. It can be removed and the last argument of the `Q_EMIT contextMenuRequested` call set

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-16 Thread Friedrich W. H. Kossebau
Am Sonntag, 16. August 2020, 00:03:53 CEST schrieb David Faure: > The code looks fine to me. Thanks for review. > The only thing I saw was case-insensitive comparison of the result of > QUrl::scheme() which is unnecessary, it always returns lowercase. Ah, was not aware (and missed the inconsist

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-15 Thread David Faure
On samedi 15 août 2020 19:20:53 CEST Friedrich W. H. Kossebau wrote: > Hi, > > what is markdownpart you ask? A KParts plugin allowing to view markdown > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or > Konqueror, being mainly a wrapper around QTextDocument::setMarkdown & > QTex

KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-15 Thread Friedrich W. H. Kossebau
Hi, what is markdownpart you ask? A KParts plugin allowing to view markdown documents rendered e.g. in Kate's preview plugin, Ark, Krusader or Konqueror, being mainly a wrapper around QTextDocument::setMarkdown & QTextBrowser. See here it being used with Kate's preview plugin: https://cdn.kde.or