Re: KDEReview for Kontrast

2020-08-22 Thread Carl Schwan
Le jeudi, juillet 30, 2020 11:16 AM, Carl Schwan a écrit : > Hi, > I would like to move Kontrast, a contrast checker application, to KDEReview. > Kontrast can check if two colors pass the WCAG 2.0 specification and save > some user's favorite color combinations. > > Some screenshots of the appl

Re: KDEReview for Kontrast

2020-08-11 Thread Michael Reeves
The odd naming is a flatpac requirement if you want the icon auto extracted. Otherwise flatpac will have to be told explicitly to rename the icon. On Tue, Aug 11, 2020, 3:38 AM Christophe Giboudeaux wrote: > On lundi 3 août 2020 23:12:25 CEST Albert Astals Cid wrote: > > > I added the icon and I

Re: KDEReview for Kontrast

2020-08-11 Thread Carl Schwan
Le lundi, août 3, 2020 11:12 PM, Albert Astals Cid a écrit : > El dilluns, 3 d’agost de 2020, a les 4:26:25 CEST, Carl Schwan va escriure: > > > Le dimanche, août 2, 2020 6:20 PM, Albert Astals Cid aa...@kde.org a écrit : > > > > > El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl Schwan

Re: KDEReview for Kontrast

2020-08-11 Thread Christophe Giboudeaux
On lundi 3 août 2020 23:12:25 CEST Albert Astals Cid wrote: > > I added the icon and I hope I installed it to the correct location: > > https://invent.kde.org/accessibility/kontrast/-/commit/8a008c1387c0234d5e > > 1d537bdd331007d7b1ff07. It was already stored in breeze-icons but I guess > > it is b

Re: KDEReview for Kontrast

2020-08-03 Thread Albert Astals Cid
El dilluns, 3 d’agost de 2020, a les 4:26:25 CEST, Carl Schwan va escriure: > Le dimanche, août 2, 2020 6:20 PM, Albert Astals Cid a écrit : > > > El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl Schwan va > > escriure: > > > > > Hi, > > > I would like to move Kontrast, a contrast chec

Re: KDEReview for Kontrast

2020-08-03 Thread Carl Schwan
Le dimanche, août 2, 2020 6:20 PM, Albert Astals Cid a écrit : > El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl Schwan va escriure: > > > Hi, > > I would like to move Kontrast, a contrast checker application, to KDEReview > > Kontrast can check if two colors pass the WCAG 2.0 specifi

Re: KDEReview for Kontrast

2020-08-03 Thread Carl Schwan
Le dimanche, août 2, 2020 2:58 PM, Nate Graham a écrit : > Hello Carl, > This looks very useful! Overall I'd say the UI is good. One thing I find > myself missing while playing around is the ability to test system > colorschemes though. That would be a really nice addition. I'm not sure this fea

Re: KDEReview for Kontrast

2020-08-03 Thread Carl Schwan
Carl Schwan https://carlschwan.eu ‐‐‐ Original Message ‐‐‐ Le dimanche, août 2, 2020 3:36 PM, Nicolas Fella a écrit  : > Hi Carl, > > a couple of nitpicks, otherwise looks neat. > > - your CMakeLists.txt does not specify a minimum Qt/KF5 version. Also > ECM 0.0.8 is likely quit

Re: KDEReview for Kontrast

2020-08-03 Thread Nate Graham
On 8/2/20 8:29 PM, Carl Schwan wrote: Le dimanche, août 2, 2020 2:58 PM, Nate Graham a écrit : Hello Carl, This looks very useful! Overall I'd say the UI is good. One thing I find myself missing while playing around is the ability to test system colorschemes though. That would be a really nice

Re: KDEReview for Kontrast

2020-08-02 Thread Albert Astals Cid
El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl Schwan va escriure: > Hi, > I would like to move Kontrast, a contrast checker application, to KDEReview > Kontrast can check if two colors pass the WCAG 2.0 specification and save > some user's favorite color combinations. > > Some scree

Re: KDEReview for Kontrast

2020-08-02 Thread Nicolas Fella
Hi Carl, a couple of nitpicks, otherwise looks neat. - your CMakeLists.txt does not specify a minimum Qt/KF5 version. Also ECM 0.0.8 is likely quite old and a bit optimistic - Setting CMAKE_CXX_STANDARD to 11 is implicitly done by ECM, no need to do that manually. It also contradicts the target

Re: KDEReview for Kontrast

2020-08-02 Thread Nate Graham
Hello Carl, This looks very useful! Overall I'd say the UI is good. One thing I find myself missing while playing around is the ability to test system colorschemes though. That would be a really nice addition. Nate On 7/30/20 3:16 AM, Carl Schwan wrote: Hi, I would like to move Kontrast, a

KDEReview for Kontrast

2020-08-02 Thread Carl Schwan
Hi, I would like to move Kontrast, a contrast checker application, to KDEReview. Kontrast can check if two colors pass the WCAG 2.0 specification and save some user's favorite color combinations. Some screenshots of the application and a design review from the VSG is available here: https://inv