Hi everyone!
On Sun, Jan 12, 2020 at 02:43:16PM +0100, Johan Ouwerkerk wrote:
> Keysmith has been in KDE review for over three weeks, so unless there
> is urgent new feedback that leaves the question: what is next?
>
> Thanks again for all your help and feedback making Keysmith much better!
Sinc
Thanks everyone for all the review feedback so far.
With the exception of the variable length array comment, I think all
feedback has been addressed.
As for the variable length array, this will be gone when MR #24 lands:
https://invent.kde.org/kde/keysmith/merge_requests/24
Keysmith has been in K
On Sat, Dec 28, 2019 at 6:38 PM Friedrich W. H. Kossebau
wrote:
>
> That one is a blocker though to pass kdereview, for what I understand from
> https://community.kde.org/ReleasingSoftware#Sanity_Checklist as linked from
> https://community.kde.org/Policies/Application_Lifecycle#kdereview
>
> At l
On 12/28/19 19:17, Jesus Varela wrote:
I am new and have tons of questions about all these emails I see.
From what I understand there is software being added to the core KDE
framework. Will this make the framework less desired due to it being
bloated with tons of features? Or is it desired to ha
Hi everyone,
I am new and have tons of questions about all these emails I see.
>From what I understand there is software being added to the core KDE
framework. Will this make the framework less desired due to it being
bloated with tons of features? Or is it desired to have more features even
if i
First of all sorry for the duplicate reply Friedrich. I messed up with
the send button earlier.
Here goes the second try:
>
> Did some usual-nitpick-CMake-code cleanup commit already (things which also
> apply to other new Plasma repos, someone might want to brush over their
> CMakeLists.txt as w
First of all: sorry for the duplicate reply Albert. There was a mixup
with the reply button on my end, unfortunately.
Here goes attempt #2:
> I think it'd be good if you used a QVarLengthArray instead of "char
> code[m_pinLength];"
>
Yes that is a known wart. There are a few issues/MRs that tou
Sending my reply on-list while Johan's resent reply to list seems stuck in
moderation:
Am Samstag, 28. Dezember 2019, 15:03:33 CET schrieb Johan Ouwerkerk:
> On Wed, Dec 18, 2019 at 5:43 PM Friedrich W. H. Kossebau
>
> wrote:
> > Other things noticed on superficial look:
> > * UI not translated
Albert Astals Cid wrote:
> I think it'd be good if you used a QVarLengthArray instead of "char
> code[m_pinLength];"
Sadly, QVarLengthArray is much less efficient, because it cannot do
variable-size stack allocation, only fixed-size stack allocation (wasting
stack space) and heap allocation for
El dimecres, 18 de desembre de 2019, a les 15:50:36 CET, Bhushan Shah va
escriure:
> Hello everyone!
>
> Keysmith (https://invent.kde.org/kde/keysmith) has been moved to
> kdereview.
>
> Keysmith is a Two-factor code generator for Plasma Mobile and Desktop
> and is using oath-toolkit for this pu
Hi Bhushan,
Am Mittwoch, 18. Dezember 2019, 15:50:36 CET schrieb Bhushan Shah:
> Hello everyone!
>
> Keysmith (https://invent.kde.org/kde/keysmith) has been moved to
> kdereview.
>
> Keysmith is a Two-factor code generator for Plasma Mobile and Desktop
> and is using oath-toolkit for this purpos
Hello everyone!
Keysmith (https://invent.kde.org/kde/keysmith) has been moved to
kdereview.
Keysmith is a Two-factor code generator for Plasma Mobile and Desktop
and is using oath-toolkit for this purpose. User interface is written in
the kirigami.
Thanks!
--
Bhushan Shah
http://blog.bshah.in
12 matches
Mail list logo
