More about kdelibs unittests

2010-12-07 Thread Jaime
Hi, I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1, and the number of failed tests has grown in a noticeable way. (also with 2 crashes). I guess that less Qt warnings usually means less unexpected crashes. Therefore I suggest to add that variable to the test target,

Re: More about kdelibs unittests

2010-12-07 Thread Stephen Kelly
Jaime wrote: > Hi, > > I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1, > and the number of failed tests has grown in a noticeable way. (also with 2 > crashes). > > I guess that less Qt warnings usually means less unexpected crashes. > Therefore I suggest to add that

Re: More about kdelibs unittests

2010-12-09 Thread David Faure
On Tuesday 07 December 2010, Jaime wrote: > Hi, > > I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1, > and the number of failed tests has grown in a noticeable way. (also with 2 > crashes). > > I guess that less Qt warnings usually means less unexpected crashes. > The

Re: More about kdelibs unittests

2010-12-09 Thread Jaime
You're right. I forgot about the tests that check something will fail with invalid input. Rigtht now, I only get 3 failures in nepomuk (without QT_FATAL_WARNINGS). And kglobaltest fails only when I have QT_NO_GLIB=1 (I used to have it because of flash plugin, but not any longer). I'll check from

Re: More about kdelibs unittests

2010-12-09 Thread Aurélien Gâteau
On 09/12/2010 17:52, David Faure wrote: On Tuesday 07 December 2010, Jaime wrote: Hi, I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1, and the number of failed tests has grown in a noticeable way. (also with 2 crashes). I guess that less Qt warnings usually means l

Re: More about kdelibs unittests

2010-12-09 Thread David Faure
On Thursday 09 December 2010, Aurélien Gâteau wrote: > On 09/12/2010 17:52, David Faure wrote: > > On Tuesday 07 December 2010, Jaime wrote: > >> Hi, > >> > >>I've run the kdelibs with the environment variable > >>QT_FATAL_WARNINGS=1, > >> > >> and the number of failed tests has grown in

Re: More about kdelibs unittests

2010-12-09 Thread Vishesh Handa
Hi. On Fri, Dec 10, 2010 at 1:03 AM, Jaime wrote: > You're right. I forgot about the tests that check something will fail > with invalid input. > > Rigtht now, I only get 3 failures in nepomuk (without QT_FATAL_WARNINGS). > Which tests don't pass in Nepomuk? I just tried the tests in kdelibs/ne

Re: More about kdelibs unittests

2010-12-10 Thread Jaime
Please, find attached my failing tests. I do not know if this is important or not, I do not have the clucene backend, and sometimes I can compile soprano, sometimes not. 2010/12/10 Vishesh Handa : > Hi. > > On Fri, Dec 10, 2010 at 1:03 AM, Jaime wrote: >> >> You're right. I forgot about the tests

Re: More about kdelibs unittests

2010-12-13 Thread Aurélien Gâteau
On 10/12/2010 00:44, David Faure wrote: Yes, this will crash with QT_FATAL_WARNINGS. So? It's good to have a unit test test border conditions too, even if these conditions lead to warnings from Qt. One could try to use QTest::ignoreMessage() [1] to skip expected error messages. Does not help.