Moving Plasma Media Center to extragear

2013-04-12 Thread Sinny Kumari
Hi! After Plasma Media Center 1.0 release, we feel that it should be moved to Extragear now. It has been moved to kdereview with link https://projects.kde.org/projects/kdereview/plasma-mediacenter/repository . we are fixing krazy issues as we go. I request you all to review this project and p

Re: Moving Plasma Media Center to extragear

2013-04-12 Thread Burkhard Lück
Am Freitag, 12. April 2013, 23:58:32 schrieb Sinny Kumari: > Hi! > > After Plasma Media Center 1.0 release, we feel that it should be moved to > Extragear now. It has been moved to kdereview with link > https://projects.kde.org/projects/kdereview/plasma-mediacenter/repository . > > we are fixin

Re: Moving Plasma Media Center to extragear

2013-04-13 Thread Albert Astals Cid
El Divendres, 12 d'abril de 2013, a les 22:01:41, Burkhard Lück va escriure: > Am Freitag, 12. April 2013, 23:58:32 schrieb Sinny Kumari: > > Hi! > > > > After Plasma Media Center 1.0 release, we feel that it should be moved to > > Extragear now. It has been moved to kdereview with link > > https

Re: Moving Plasma Media Center to extragear

2013-04-22 Thread Sinny Kumari
Hi all, Please review it :) Thanks On Fri, Apr 12, 2013 at 11:58 PM, Sinny Kumari wrote: > Hi! > > After Plasma Media Center 1.0 release, we feel that it should be moved to > Extragear now. It has been moved to kdereview with link > https://projects.kde.org/projects/kdereview/plasma-mediacen

Re: Moving Plasma Media Center to extragear

2013-04-22 Thread David Edmundson
Summary: Few minor comments. Nothing particularly exciting. All in all I was fairly impressed with the code, it's neat and tidy and you've had 2 releases which is the right approach to getting in Extragear Assuming you've addressed Albert's comments, +1 from me on this. Comments --- FilterPlay

Re: Moving Plasma Media Center to extragear

2013-04-22 Thread Albert Astals Cid
El Dilluns, 22 d'abril de 2013, a les 01:22:37, Sinny Kumari va escriure: > Hi all, Hi you, please read the reviews me made. Cheers, Albert > Please review it :) > > Thanks > > On Fri, Apr 12, 2013 at 11:58 PM, Sinny Kumari wrote: > > Hi! > > > > After Plasma Media Center 1.0 release, we f

Re: Moving Plasma Media Center to extragear

2013-04-22 Thread Albert Astals Cid
El Dimarts, 23 d'abril de 2013, a les 00:06:27, Sinny Kumari va escriure: > Thank you all for giving useful comments. > > Sorry, I didn't get email which was replied directly to > kde-core-devel@kde.org since I was not subscribed to this list. I checked > all replies from Mailing List archives and

Re: Moving Plasma Media Center to extragear

2013-04-23 Thread Sinny Kumari
Thank you all for giving useful comments. Sorry, I didn't get email which was replied directly to kde-core-devel@kde.org since I was not subscribed to this list. I checked all replies from Mailing List archives and now I subscribed to this list too. Will do changes as suggested and will let you k

Re: Moving Plasma Media Center to extragear

2013-05-16 Thread Shantanu Tushar Jha
Hi David, Thanks for the points, we have fixed everything you mentioned. For the d-pointer and SONAME issues, I understand we should be more vigilant from now on and take care of these things. While the mistake in the first release is undoable, I think its better we fix things right now, as we don

Re: Moving Plasma Media Center to extragear

2013-05-21 Thread Sinny Kumari
Hi, Any news on this? Does PMC look ok now from your side so that we can move it to extragear ? If not, please let us know what all changes we still need to do. Thanks On Mon, May 13, 2013 at 8:18 PM, Shantanu Tushar Jha wrote: > Hi David, > > Thanks for the points, we have fixed everything y

Re: Moving Plasma Media Center to extragear

2013-05-21 Thread Burkhard Lück
Am Dienstag, 21. Mai 2013, 10:07:50 schrieb Sinny Kumari: > Hi, > > Any news on this? Does PMC look ok now from your side so that we can move > it to extragear ? > > If not, please let us know what all changes we still need to do. > still i18n() calls in *qml files, but no message extraction --

Re: Moving Plasma Media Center to extragear

2013-05-24 Thread Sinny Kumari
On Wed, May 22, 2013 at 11:41 AM, Burkhard Lück wrote: > Am Dienstag, 21. Mai 2013, 10:07:50 schrieb Sinny Kumari: > > Hi, > > > > Any news on this? Does PMC look ok now from your side so that we can move > > it to extragear ? > > > > If not, please let us know what all changes we still need to d

Re: Moving Plasma Media Center to extragear

2013-05-24 Thread Burkhard Lück
Am Mittwoch, 22. Mai 2013, 08:11:49 schrieb Burkhard Lück: > Am Dienstag, 21. Mai 2013, 10:07:50 schrieb Sinny Kumari: > > Hi, > > > > Any news on this? Does PMC look ok now from your side so that we can move > > it to extragear ? > > > > If not, please let us know what all changes we still need

Re: Moving Plasma Media Center to extragear

2013-05-24 Thread David Edmundson
>From my side (as someone who reviewed this) I'm happy for this to go to extragear too. David On Tue, May 21, 2013 at 5:37 AM, Sinny Kumari wrote: > Hi, > > Any news on this? Does PMC look ok now from your side so that we can move it > to extragear ? > > If not, please let us know what all chang

Re: Moving Plasma Media Center to extragear

2013-05-25 Thread Sinny Kumari
Thanks to all of you for valuable feedback. With your positive response, I have made request to sysadmin now https://bugs.kde.org/show_bug.cgi?id=317649 . On Sat, May 25, 2013 at 4:16 AM, David Edmundson wrote: > From my side (as someone who reviewed this) I'm happy for this to go > to extragea