On Thu, Jan 3, 2013 at 11:12 PM, Martin Klapetek
wrote:
>
> Anyways, anything else that should be fixed in the library?
>
If there are no more comments, I'm going to ask sysadmins to move it
tonight (it's been in review since October).
Thanks everyone for your reviews and comments!
Cheers
--
M
On Thu, Jan 3, 2013 at 9:52 PM, Albert Astals Cid wrote:
> El Dimecres, 2 de gener de 2013, a les 15:31:30, Martin Klapetek va
> escriure:
> > On Sun, Dec 30, 2012 at 6:34 PM, Albert Astals Cid
> wrote:
> > > AttendeeInfo misses a d_ptr?
> >
> > Are you deleting the d_ptr? Maybe i'm missing some
El Dimecres, 2 de gener de 2013, a les 15:31:30, Martin Klapetek va escriure:
> On Sun, Dec 30, 2012 at 6:34 PM, Albert Astals Cid wrote:
> > AttendeeInfo misses a d_ptr?
>
> Are you deleting the d_ptr? Maybe i'm missing something but for example you
>
> > don't seem to delete the d_ptr of Paged
On Sat, Dec 29, 2012 at 12:35 PM, Raymond Wooninck wrote:
> Hi Martin,
>
> On Saturday 29 December 2012 01:25:43 Martin Klapetek wrote:
> >
> > I finally got around finishing d-pointerizing the whole library, it's all
> > in master now. Please review.
> >
> I made a small adjustment in the CMakeLi
On Sun, Dec 30, 2012 at 6:34 PM, Albert Astals Cid wrote:
>
> AttendeeInfo misses a d_ptr?
Are you deleting the d_ptr? Maybe i'm missing something but for example you
> don't seem to delete the d_ptr of PagedListJob, no?
>
I reworked the dpointers a bit, classes deriving directly from Facebook*
Hi Martin,
On Saturday 29 December 2012 01:25:43 Martin Klapetek wrote:
>
> I finally got around finishing d-pointerizing the whole library, it's all
> in master now. Please review.
>
I made a small adjustment in the CMakeLists.txt files to have a correctly
versioned shared library. I noticed
El Dissabte, 29 de desembre de 2012, a les 01:25:43, Martin Klapetek va
escriure:
> On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid wrote:
> > > The data classes are finally done - all of them now use d-pointers and
> >
> > none
> >
> > > are qobject; I've added the qobject-parsers as Kevin s
On Sun, Dec 30, 2012 at 6:22 PM, Albert Astals Cid wrote:
> You missed one place
>
> ./libkfbapi/CMakeLists.txt:99: ${CMAKE_BINARY_DIR}/config.h
>
Damn, I blame kdevelop's "find in files" :P Fixed, thanks.
Cheers
--
Martin Klapetek | KDE Developer
El Diumenge, 30 de desembre de 2012, a les 17:50:42, Martin Klapetek va
escriure:
> On Sun, Dec 30, 2012 at 5:07 PM, Albert Astals Cid wrote:
> > What's config.h.cmake used for?
>
> Looks like it was used for supporting kdepim_44_compat mode, which is now
> discouraged and was removed from this
On Sun, Dec 30, 2012 at 5:07 PM, Albert Astals Cid wrote:
>
> What's config.h.cmake used for?
>
Looks like it was used for supporting kdepim_44_compat mode, which is now
discouraged and was removed from this library recently. Therefore this file
is no longer useful, so I removed it.
Cheers
--
On Sunday 30 December 2012, Albert Astals Cid wrote:
> El Dissabte, 29 de desembre de 2012, a les 01:25:43, Martin Klapetek va
>
> escriure:
> > On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid wrote:
> > > > The data classes are finally done - all of them now use d-pointers
> > > > and
> > >
>
El Dissabte, 29 de desembre de 2012, a les 01:25:43, Martin Klapetek va
escriure:
> On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid wrote:
> > > The data classes are finally done - all of them now use d-pointers and
> >
> > none
> >
> > > are qobject; I've added the qobject-parsers as Kevin s
On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid wrote:
> > The data classes are finally done - all of them now use d-pointers and
> none
> > are qobject; I've added the qobject-parsers as Kevin suggested, please
> give
> > it a look.
>
> You sure? I still see a lots of d-pointers missing (AllEv
On Wed, Nov 7, 2012 at 8:28 PM, Albert Astals Cid wrote:
> > > Also you have some classes without the export thingie, like
> AttendeeInfo
> > > or
> > > the facebookTimeToKDateTime function
> >
> > They are not to be exported, only for internal purposes.
>
> Why are they in installed headers then
El Dimecres, 7 de novembre de 2012, a les 20:20:56, Martin Klapetek va
escriure:
> On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid wrote:
> > El Dilluns, 5 de novembre de 2012, a les 22:59:43, Martin Klapetek va
> >
> > escriure:
> > > On Mon, Nov 5, 2012 at 7:52 PM, Pino Toscano wrote:
> > >
El Dilluns, 5 de novembre de 2012, a les 22:59:43, Martin Klapetek va
escriure:
> On Mon, Nov 5, 2012 at 7:52 PM, Pino Toscano wrote:
> > Some notes:
> >
> > - as others have pointed out, public classes should be better use
> > d-pointers; for the jobs hierarchy, you could use a shared d-pointer
Hi,
Alle sabato 27 ottobre 2012, Martin Klapetek ha scritto:
> I'd like to move libkfacebook, the foundation for akonadi-facebook
> resource, into extragear. It's been in use for a while, lots of
> distro ship it bundled with akonadi-facebook resource, which is now
> becaming part of kdepim-runtim
On Sat, Nov 3, 2012 at 1:59 PM, Albert Astals Cid wrote:
>
> You don't seem to be using d-pointers, can you please fix that?
>
Yes, I'm halfway done together with Kevin's suggestions to get rid of
QObjects, but I didn't have time to finish it yet, sorry. Will update once
done.
Cheers
--
Martin
El Dissabte, 27 d'octubre de 2012, a les 11:00:42, Martin Klapetek va
escriure:
> Hi,
>
> I'd like to move libkfacebook, the foundation for akonadi-facebook
> resource, into extragear. It's been in use for a while, lots of distro ship
> it bundled with akonadi-facebook resource, which is now beca
Am Mittwoch, 31. Oktober 2012, 11:52:53 schrieb Martin Klapetek:
> On Wed, Oct 31, 2012 at 11:44 AM, Burkhard Lück wrote:
> > I see not code to load the translation catalog libkfacebook (old name) or
> > libkfbapi (new name).
> >
> > Afaik you should use KCatalogLoader to load your translation ca
On Wed, Oct 31, 2012 at 11:44 AM, Burkhard Lück wrote:
> I see not code to load the translation catalog libkfacebook (old name) or
> libkfbapi (new name).
>
> Afaik you should use KCatalogLoader to load your translation catalog
>
I was actually just about to ask this - i18n is used only in three
Am Samstag, 27. Oktober 2012, 11:00:42 schrieb Martin Klapetek:
> Hi,
>
> I'd like to move libkfacebook, the foundation for akonadi-facebook
> resource, into extragear. It's been in use for a while, lots of distro ship
> it bundled with akonadi-facebook resource, which is now becaming part of
> kd
On Sunday, 2012-10-28, Kevin Krammer wrote:
> On Sunday, 2012-10-28, Martin Klapetek wrote:
> > On Sat, Oct 27, 2012 at 6:05 PM, Kevin Krammer wrote:
> > > - the *Info classes seem to be normal data classes, IMHO they don't
> > > need to be
> > > QObjects but rather "value types"
> >
> > This is
On Mon, Oct 29, 2012 at 11:52 AM, Martin Klapetek wrote:
>
> Also heads up - the latest changes somehow broke the akonadi resource (the
> one in patch for kdepim-runtime on reviewboard), I'm on it, will keep you
> posted.
>
All fixed. If you're testing this, please update both your libkfacebook
On Mon, Oct 29, 2012 at 11:44 AM, Kevin Krammer wrote:
>
> > Good points, all fixed.
>
> Almost :)
> FacebookJob::m_queryItems is still there. can probably also remove the
> typedef
> for QueryItem.
>
Damn, overlooked. Fixed now.
Also heads up - the latest changes somehow broke the akonadi reso
On Monday, 2012-10-29, Martin Klapetek wrote:
> On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer wrote:
> > I think you can remove m_accessToken, m_path and m_queryItems from
> > FacebookJob.
> > Access token and path are already set on m_url and addQueryItem can be
> > implemented to just call m_ur
On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer wrote:
>
> I think you can remove m_accessToken, m_path and m_queryItems from
> FacebookJob.
> Access token and path are already set on m_url and addQueryItem can be
> implemented to just call m_url.addQueryItem().
>
> Also, virtual void start() = 0
On Monday, 2012-10-29, Martin Klapetek wrote:
> On Sun, Oct 28, 2012 at 8:03 PM, Kevin Krammer wrote:
> > > This is for the parsing purposes - the library uses QJson
> > > parser/mapper, which automagically maps the received json data to
> > > qobjects, otherwise there would have to be manual pars
On Sun, Oct 28, 2012 at 8:03 PM, Kevin Krammer wrote:
>
> > This is for the parsing purposes - the library uses QJson parser/mapper,
> > which automagically maps the received json data to qobjects, otherwise
> > there would have to be manual parsing everywhere (and the facebook jsons
> > are huge
On Sunday, 2012-10-28, Martin Klapetek wrote:
> On Sat, Oct 27, 2012 at 6:05 PM, Kevin Krammer wrote:
> > - FacebookJob(QString, QString) calls setCapabilities,
> > FacebookJob(QString) does not
> >
> > - Is the FacebookJob(QString) constructor really needed. It seems all
> > jobs need a path
>
On Sat, Oct 27, 2012 at 7:39 PM, John Layt wrote:
>
> Yeap, was just about to ask that question: does this use of the
> Facebook name comply with their trademark use policy? I had a quick
> look but their policy isn't as detailed as the Google policy which was
> very clear on the point. Perhaps
On Sat, Oct 27, 2012 at 6:05 PM, Kevin Krammer wrote:
> I had a cursory look and found a couple of things. CCing the original
> authors
> so they can provide input.
>
> - The job classes should have a QObject *parent = 0 argument and pass
> parent
> on to KJob's constructor.
>
> - Some of the con
On Samstag, 27. Oktober 2012 19:39:40 CEST, John Layt wrote:
> I think calling anything libktrademark is never a good idea as it
> could be confused for something created by the trademark holder, but
> something like akonadi-resource-trademark is perhaps more acceptable
> as it is a more functiona
On 27 October 2012 17:58, Rolf Eike Beer wrote:
> Am Samstag, 27. Oktober 2012, 11:00:42 schrieb Martin Klapetek:
>> Hi,
>>
>> I'd like to move libkfacebook, the foundation for akonadi-facebook
>> resource, into extragear. It's been in use for a while, lots of distro ship
>> it bundled with akonad
> I don't have any knowledge about this, but recently there was some library
> named "libkgoogle" which has been renamed to something other to avoid
> possible trademark hazard. This has been in the thread "Review request:
> moving libkgoogle to extragear" starting 2012-05-26.
It has been renamed
Am Samstag, 27. Oktober 2012, 11:00:42 schrieb Martin Klapetek:
> Hi,
>
> I'd like to move libkfacebook, the foundation for akonadi-facebook
> resource, into extragear. It's been in use for a while, lots of distro ship
> it bundled with akonadi-facebook resource, which is now becaming part of
> kd
Hi,
On Saturday, 2012-10-27, Martin Klapetek wrote:
> Hi,
>
> I'd like to move libkfacebook, the foundation for akonadi-facebook
> resource, into extragear. It's been in use for a while, lots of distro ship
> it bundled with akonadi-facebook resource, which is now becaming part of
> kdepim-runtim
37 matches
Mail list logo
