Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-16 Thread Matthias Fuchs
Am Samstag 15 Januar 2011, 15:08:28 schrieb Thiago Macieira: On Saturday, 15 de January de 2011 12:28:38 Ingo Klöcker wrote: On Friday 14 January 2011, Thiago Macieira wrote: On Friday, 14 de January de 2011 21:49:01 Ingo Klöcker wrote: On Friday 14 January 2011, Thiago Macieira wrote:

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-15 Thread Ingo Klöcker
On Friday 14 January 2011, Thiago Macieira wrote: On Friday, 14 de January de 2011 21:49:01 Ingo Klöcker wrote: On Friday 14 January 2011, Thiago Macieira wrote: On Friday, 14 de January de 2011 13:46:19 Sebastian Trueg wrote: However, the query parser still uses static QRegExp objects

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-15 Thread Matthias Fuchs
Am Samstag 15 Januar 2011, 15:08:28 schrieb Thiago Macieira: On Saturday, 15 de January de 2011 12:28:38 Ingo Klöcker wrote: On Friday 14 January 2011, Thiago Macieira wrote: On Friday, 14 de January de 2011 21:49:01 Ingo Klöcker wrote: On Friday 14 January 2011, Thiago Macieira wrote:

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-14 Thread Sebastian Trueg
However, the query parser still uses static QRegExp objects which seems a bad idea, isn't that right? Thus, I suppose it would be better to wrap them in a mutex'ed object and create that via K_GLOBAL_STATIC? Cheers, Sebastian On 01/14/2011 01:17 AM, Thiago Macieira wrote: On Thursday, 13 de

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-14 Thread Thiago Macieira
On Friday, 14 de January de 2011 13:46:19 Sebastian Trueg wrote: However, the query parser still uses static QRegExp objects which seems a bad idea, isn't that right? static QRegExp are a bad idea regardless of whether threading is involved or not. Thus, I suppose it would be better to wrap

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-14 Thread Albert Astals Cid
A Divendres, 14 de gener de 2011, Sebastian Trueg va escriure: However, the query parser still uses static QRegExp objects which seems a bad idea, isn't that right? Thus, I suppose it would be better to wrap them in a mutex'ed object and create that via K_GLOBAL_STATIC? Why would you want to

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-14 Thread Thiago Macieira
On Friday, 14 de January de 2011 20:28:04 Andreas Pakulat wrote: On 14.01.11 17:51:56, Albert Astals Cid wrote: A Divendres, 14 de gener de 2011, Sebastian Trueg va escriure: However, the query parser still uses static QRegExp objects which seems a bad idea, isn't that right? Thus,

Multiple QRegExp crashes when multithreading in KRunner

2011-01-13 Thread Matthias Fuchs
Hi, There are some crashes related to QRegExp and multithreading, so they appear when using KRunner. One happens in Nepomuk::Query::QueryParser::parse, a static method that uses globally defined QRegExps. [1] Now I wonder what the best solution is for this specific problem. Last week I

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-13 Thread Milian Wolff
Matthias Fuchs, 13.01.2011: Hi, There are some crashes related to QRegExp and multithreading, so they appear when using KRunner. QRegExp is not threadsafe, you either have to guard it with a mutex or make sure it's not shared between threads. Bye -- Milian Wolff m...@milianw.de

Re: Multiple QRegExp crashes when multithreading in KRunner

2011-01-13 Thread Aaron J. Seigo
On Thursday, January 13, 2011, Thiago Macieira wrote: Nah. Just create a copy on the stack: easy enough, indeed. committed and backported; thanks to both you and Matthias for your efforts on this. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7