Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2013-01-15 Thread André Wöbbeking
On Monday 14 January 2013 20:51:57 Albert Astals Cid wrote: > El Dilluns, 14 de gener de 2013, a les 20:36:03, André Wöbbeking va escriure: > > On Monday 14 January 2013 20:25:21 Albert Astals Cid wrote: > > > If you think that packagers should be informed about this change what > > > are you wai

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2013-01-14 Thread Alexander Neundorf
On Monday 14 January 2013, André Wöbbeking wrote: > On Monday 14 January 2013 20:25:21 Albert Astals Cid wrote: > > El Dilluns, 14 de gener de 2013, a les 20:02:30, André Wöbbeking va > > escriure: > > > Hi Albert, > > > > > > On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: > > > > Of

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2013-01-14 Thread Albert Astals Cid
El Dilluns, 14 de gener de 2013, a les 20:36:03, André Wöbbeking va escriure: > On Monday 14 January 2013 20:25:21 Albert Astals Cid wrote: > > El Dilluns, 14 de gener de 2013, a les 20:02:30, André Wöbbeking va > > escriure: > > > Hi Albert, > > > > > > On Monday 08 October 2012 22:40:55 Albert

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2013-01-14 Thread André Wöbbeking
On Monday 14 January 2013 20:25:21 Albert Astals Cid wrote: > El Dilluns, 14 de gener de 2013, a les 20:02:30, André Wöbbeking va escriure: > > Hi Albert, > > > > On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: > > > Of course, enabling building the tests by defaults makes compilation

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2013-01-14 Thread Albert Astals Cid
El Dilluns, 14 de gener de 2013, a les 20:02:30, André Wöbbeking va escriure: > Hi Albert, > > On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: > > Of course, enabling building the tests by defaults makes compilation times > > a bit longer, but I do think that the benefits far surpass t

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2013-01-14 Thread André Wöbbeking
Hi Albert, On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: > Of course, enabling building the tests by defaults makes compilation times a > bit longer, but I do think that the benefits far surpass the problems and > for people with really slow machines and/or needs to recompile stuff

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-09 Thread Albert Astals Cid
El Dilluns, 8 d'octubre de 2012, a les 22:40:55, Albert Astals Cid va escriure: > Hi fellow kde-core-develers, i was thinking that from time to time someone > commits some code that breaks the building of the tests. > > This happens because people is not aware that those parts are unit tested. >

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-09 Thread alpine . art . de
> Actually I've always been unsure why packagers don't run unit tests... > Maybe this would help. Because sometimes tests require certain "features" of the environment when building (read: running the test), like running X or network, which will make the whole build fail if not present.

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-09 Thread Laszlo Papp
> Because the tests are broken in certain environments (just like last > time on Harmattan with the frameworks branch) and due to the lack of > time on the packagers' side to fix upstream bugs, they choose the > simpler way as a temporary workaround. Therefore, they can proceed > with the project,

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-09 Thread Laszlo Papp
> +1 for always building unit tests! > Actually I've always been unsure why packagers don't run unit tests... > Maybe this would help. Because the tests are broken in certain environments (just like last time on Harmattan with the frameworks branch) and due to the lack of time on the packagers' si

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Aleix Pol
On Mon, Oct 8, 2012 at 10:40 PM, Albert Astals Cid wrote: > Hi fellow kde-core-develers, i was thinking that from time to time someone > commits some code that breaks the building of the tests. > > This happens because people is not aware that those parts are unit tested. > > I think that by enabl

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Martin Gräßlin
On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: > Hi fellow kde-core-develers, i was thinking that from time to time someone > commits some code that breaks the building of the tests. > > This happens because people is not aware that those parts are unit tested. > > I think that by en

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Andreas Hartmetz
On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote: > Hi fellow kde-core-develers, i was thinking that from time to time someone > commits some code that breaks the building of the tests. > > This happens because people is not aware that those parts are unit tested. > > I think that by en

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Ben Cooksley
On Tue, Oct 9, 2012 at 9:55 AM, Lamarque V. Souza wrote: > Em Monday 08 October 2012, Àlex Fiestas escreveu: > >> Anything to make developers (including myself) more unit test aware, > >> I'm all for it, even if it helps only a little bit. > > > > +1 +1 from me as well. > > > > -- > > Lamarque V

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Lamarque V. Souza
Em Monday 08 October 2012, Àlex Fiestas escreveu: > Anything to make developers (including myself) more unit test aware, > I'm all for it, even if it helps only a little bit. +1 -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Allen Winter
On Monday 08 October 2012 10:40:55 PM Albert Astals Cid wrote: > Hi fellow kde-core-develers, i was thinking that from time to time someone > commits some code that breaks the building of the tests. > > This happens because people is not aware that those parts are unit tested. > > I think that b

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Àlex Fiestas
Anything to make developers (including myself) more unit test aware, I'm all for it, even if it helps only a little bit.

RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-08 Thread Albert Astals Cid
Hi fellow kde-core-develers, i was thinking that from time to time someone commits some code that breaks the building of the tests. This happens because people is not aware that those parts are unit tested. I think that by enabling the building of the tests by default we at least make sure the