Re: Re: Ksshaskpass ?

2014-12-15 Thread Martin Gräßlin
On Sunday 14 December 2014 15:33:27 Thomas Lübking wrote: > On Sonntag, 14. Dezember 2014 13:52:51 CEST, Jeremy Whiting wrote: > > Martin, Thomas, > > > > Is the implementation of InputGuard at > > https://github.com/luebking/qarma/commit/b568dd14d6e1f661791c4d67245c614f1 > > dc1986f with > > http

Re: Re: Ksshaskpass ?

2014-12-14 Thread Jeremy Whiting
Martin, Thomas, Is the implementation of InputGuard at https://github.com/luebking/qarma/commit/b568dd14d6e1f661791c4d67245c614f1dc1986f with https://github.com/luebking/qarma/commit/3199c0a9810ed8f792b415e890425be8f2e8034a complete then? should we copy that into kwidgetsaddons and use it in kpass

Re: Re: Ksshaskpass ?

2014-12-12 Thread Martin Gräßlin
On Friday 12 December 2014 16:11:25 Thomas Lübking wrote: > On Freitag, 12. Dezember 2014 08:00:45 CEST, Martin Gräßlin wrote: > > I'd suggest to do a platform check as on Wayland it cannot work > > (grab keyboard fails). > > You're certainly right in that the guarding is entirely superfluous on >

Re: Re: Ksshaskpass ?

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 23:25:55 Thomas Lübking wrote: > https://github.com/luebking/qarma/commit/b568dd14d6e1f661791c4d67245c614f1dc > 1986f > > The InputGuard class should handle everything. > In case you need it for QGraphicsWidget's, you may have to adjust the test > functions, but in gen

Re: Re: Re: Ksshaskpass ?

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 10:37:22 Jeremy Whiting wrote: > Martin, > > Thanks for the review. I see what you mean, is there an example of doing > that on X11, also does that make it so ksshaskpass (or kpassworddialog) > won't work on wayland? Concerning Wayland: on this windowing system doesn'

Re: Re: Ksshaskpass ?

2014-12-11 Thread Jeremy Whiting
Martin, Thanks for the review. I see what you mean, is there an example of doing that on X11, also does that make it so ksshaskpass (or kpassworddialog) won't work on wayland? At any rate if you can point me to another example that does this I'll put a patch for KPasswordDialog on reviewboard (unl

Re: Re: Ksshaskpass ?

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 08:33:48 Jeremy Whiting wrote: > ksshaskspass has been in kdereview and has been improved since it got > there. Is it ready to be moved to kde/workspace ? Sorry for being late for the review. I just cloned the repo and did a quick look for a common problem on X11: the