Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/#review36168 --- You mention running tests, but it doesn't really count since no

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/ --- (Updated July 19, 2013, 11:56 p.m.) Review request for kdelibs and David F

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

> On July 19, 2013, 6:25 p.m., David Faure wrote: > > You mention running tests, but it doesn't really count since no test is > > testing this clipboard stuff at the moment :-) Sorry. I attached an earlier version of the patch by mistake. :( I will attach the right one after making the changes

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/ --- (Updated July 20, 2013, 2:06 p.m.) Review request for kdelibs and David Fa

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/#review36226 --- kio/kio/clipboardupdater.cpp

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

> On July 20, 2013, 9:46 p.m., David Faure wrote: > > kio/kio/clipboardupdater_p.h, line 34 > > > > > > I'm confused. If the user presses Undo, the whole copy/move operation > > is undone, not just one URL out of

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/ --- (Updated July 21, 2013, 6:05 a.m.) Review request for kdelibs and David Fa

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/#review36244 --- Ship it! Ah, now I understand. Before hitting Undo, the user c

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/ --- (Updated July 21, 2013, 6:32 p.m.) Status -- This change has been mar

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/#review36267 --- This review has been submitted with commit e4b786f6df87aba2269

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/#review36198 --- Thanks for the unittest; I don't see the added documentation th

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

> On July 20, 2013, 8:20 a.m., David Faure wrote: > > Thanks for the unittest; I don't see the added documentation though? *sigh* I forgot to commit my changes before I generated the diff this time. This was the original patch I was wanted to post. Not the one I should have uploaded this time