Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-03-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review53742 --- This review has been submitted with commit

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-03-22 Thread kdeuser56 kdeuser56
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- (Updated March 22, 2014, 11:28 a.m.) Status -- This change has been

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-27 Thread kdeuser56 kdeuser56
On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote: Here's my vote then. Unless there's concern, push it in some days™ (ie. tuesday or so, should leave enough time to cry out) kdeuser56 kdeuser56 wrote: push it sounds like I should push it, however I can't do it, as I do not have

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-17 Thread Thomas Lübking
On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote: Here's my vote then. Unless there's concern, push it in some days™ (ie. tuesday or so, should leave enough time to cry out) kdeuser56 kdeuser56 wrote: push it sounds like I should push it, however I can't do it, as I do not have

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-17 Thread Frank Reininghaus
On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote: Here's my vote then. Unless there's concern, push it in some days™ (ie. tuesday or so, should leave enough time to cry out) kdeuser56 kdeuser56 wrote: push it sounds like I should push it, however I can't do it, as I do not have

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-16 Thread kdeuser56 kdeuser56
On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote: Here's my vote then. Unless there's concern, push it in some days™ (ie. tuesday or so, should leave enough time to cry out) kdeuser56 kdeuser56 wrote: push it sounds like I should push it, however I can't do it, as I do not have

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-08 Thread kdeuser56 kdeuser56
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- (Updated Feb. 8, 2014, 10:02 a.m.) Review request for kdelibs and Frank

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-08 Thread Frank Reininghaus
On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: tried to center align it? kdeuser56 kdeuser56 wrote: Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. In case of the iconlabel the icon itself would be on the exact same position as

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-08 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review49252 --- Ship it! Here's my vote then. Unless there's concern, push

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

2014-02-08 Thread kdeuser56 kdeuser56
On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote: Here's my vote then. Unless there's concern, push it in some days™ (ie. tuesday or so, should leave enough time to cry out) push it sounds like I should push it, however I can't do it, as I do not have a dev account. Could you push it