Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: > > Hello Aurelien, > > > > Though I have nothing to say against the current design of your kmessagebox > > widget, something I miss in your implementation is the possibility for a > > widget style to override/replace your rendering.

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: > > Hello Aurelien, > > > > Though I have nothing to say against the current design of your kmessagebox > > widget, something I miss in your implementation is the possibility for a > > widget style to override/replace your rendering.

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 11:44 a.m., Albert Astals Cid wrote: > > kdeui/widgets/kmessagewidget.h, line 134 > > > > > > I personally prefer all the variables having a name in the header too > > even if in this case it's pr

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: > > Hello Aurelien, > > > > Though I have nothing to say against the current design of your kmessagebox > > widget, something I miss in your implementation is the possibility for a > > widget style to override/replace your rendering.

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 10:17 a.m., Hugo Pereira Da Costa wrote: > > Also, I wanted to add that Gtk already has a widget similar to your idea, > > called GtkInfoBar, and which is rendered by oxygen-gtk like in the > > screenshot below: > > > > http://simplest-image-hosting.net/jpg-0-plasma-desktopou

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: > > Hello Aurelien, > > > > Though I have nothing to say against the current design of your kmessagebox > > widget, something I miss in your implementation is the possibility for a > > widget style to override/replace your rendering.

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On April 29, 2011, 7:09 p.m., Jarosław Staniek wrote: > > Ship it! > > > > PS: the callouts I have implemented: > > http://simplest-image-hosting.net/jpg-0-plasma-desktophm4013 > > It's BC with your API. Interesting! I am not sure however using a KMessageWidget is the best choice here: it l

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: > > Hello Aurelien, > > > > Though I have nothing to say against the current design of your kmessagebox > > widget, something I miss in your implementation is the possibility for a > > widget style to override/replace your rendering.

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: > > Hello Aurelien, > > > > Though I have nothing to say against the current design of your kmessagebox > > widget, something I miss in your implementation is the possibility for a > > widget style to override/replace your rendering.

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On May 1, 2011, 11:44 a.m., Albert Astals Cid wrote: > > You seem to be missing the addition of the uppercase include in > > kdelibs/includes i already fixed that :) > On May 1, 2011, 11:44 a.m., Albert Astals Cid wrote: > > kdeui/widgets/kmessagewidget.h, line 26 > >

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3007 --- You seem to be missing the addition of the uppercase include in

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3003 --- Also, I wanted to add that Gtk already has a widget similar to y

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3002 --- Hello Aurelien, Though I have nothing to say against the curre

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 30, 2011, 1:10 p.m.) Review request for kdelibs. Changes

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review2984 --- I cannot properly review your code. Ill just say I like this new

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review2971 --- Ship it! - Jarosław On April 29, 2011, 1:44 p.m., Aurélien Gâ

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review2970 --- Ship it! PS: the callouts I have implemented: http://simplest-

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review2969 --- kdeui/widgets/kmessagewidget.cpp

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On April 28, 2011, 8:07 p.m., Jarosław Staniek wrote: > > I admit I reviewed the code extensively since I used it in Kexi already, > > extending by adding default action feature, callouts, and autodeletion. > > Good job! > > > > Please look at these supplementary notes too - I'd like to star

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 29, 2011, 1:44 p.m.) Review request for kdelibs. Changes

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

> On April 28, 2011, 8:07 p.m., Jarosław Staniek wrote: > > I admit I reviewed the code extensively since I used it in Kexi already, > > extending by adding default action feature, callouts, and autodeletion. > > Good job! > > > > Please look at these supplementary notes too - I'd like to star

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review2948 --- Ship it! I admit I reviewed the code extensively since I used i

Review Request: Add KMessageWidget, an alternative to KMessageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- Review request for kdelibs. Summary --- KMessageWidget is a new widge