Re: Review Request: Add a FindQtMobility.cmake file

2011-06-17 Thread Alexander Neundorf
On Friday 17 June 2011, Arjen Hiemstra wrote: > > On June 13, 2011, 8:05 a.m., Alexander Neundorf wrote: > > > Looks good in general. > > > > > > The foreach() loop uses new features from cmake 2.8.0, and KDE depends > > > on cmake 2.6.4 (later on this year we will require probably cmake > > > 2.8

Re: Review Request: Add a FindQtMobility.cmake file

2011-06-17 Thread Arjen Hiemstra
> On June 13, 2011, 8:05 a.m., Alexander Neundorf wrote: > > Looks good in general. > > > > The foreach() loop uses new features from cmake 2.8.0, and KDE depends on > > cmake 2.6.4 (later on this year we will require probably cmake 2.8.6, then > > it will be fine), so this must not be used. >

Re: Review Request: Add a FindQtMobility.cmake file

2011-06-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101568/#review3926 --- Ship it! I'm obviously fine with it, once the changes Alex sugg

Re: Review Request: Add a FindQtMobility.cmake file

2011-06-13 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101568/#review3859 --- Looks good in general. The foreach() loop uses new features fro

Re: Review Request: Add a FindQtMobility.cmake file

2011-06-11 Thread Rolf Eike Beer
Am Freitag, 10. Juni 2011, 19:18:55 schrieb Arjen Hiemstra: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101568/ > --- > > Review

Review Request: Add a FindQtMobility.cmake file

2011-06-11 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101568/ --- Review request for kdelibs and Sebastian Kügler. Summary --- As reque