Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23951 --- This review has been submitted with commit 23b5b55c04b3b8a5d75

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23950 --- This review has been submitted with commit feac020d92bdb199341

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23949 --- This review has been submitted with commit 011e5acd647cc5a30d2

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-23 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23891 --- Ping? If there is no strong objection, I will push the proposed

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-23 Thread George Kiagiadakis
> On Dec. 23, 2012, 10:27 a.m., Jekyll Wu wrote: > > Ping? If there is no strong objection, I will push the proposed change > > (timeout adjusted to 15min) tomorrow so that it can catch 4.9.5 I'd say go ahead and commit it. It's better than the previous situation. - George -

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread Rolf Eike Beer
Am , schrieb Jekyll Wu: 于 2012年12月10日 19:27, Rolf Eike Beer 写道: The only downside is some backtrace might be lost. But I don't think that is a big deal. Crashes during shutdown are rare cases nowadays(I hope I'm right), and users noticing those crashes only hours later are the rare case in ra

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread Jekyll Wu
于 2012年12月10日 19:27, Rolf Eike Beer 写道: The only downside is some backtrace might be lost. But I don't think that is a big deal. Crashes during shutdown are rare cases nowadays(I hope I'm right), and users noticing those crashes only hours later are the rare case in rare cases (but very annoying)

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread Rolf Eike Beer
The only downside is some backtrace might be lost. But I don't think that is a big deal. Crashes during shutdown are rare cases nowadays(I hope I'm right), and users noticing those crashes only hours later are the rare case in rare cases (but very annoying). I regularly get them, most times so

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread George Kiagiadakis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23260 --- Your logic sounds sane. Perhaps it is startkde that should stop

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread George Kiagiadakis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23259 --- Your logic sounds sane. Perhaps it is startkde that should stop

Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-10 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/ --- Review request for kde-workspace and George Kiagiadakis. Description -