Re: Review Request: Dolphin zoom with CTRL+MouseWheel

2011-08-30 Thread Dominik Haumann
> On Aug. 30, 2011, 4:55 p.m., Dominik Haumann wrote: > > dolphin/src/views/dolphinview.cpp, line 691 > > > > > > Just a maybe: > > if event->delta() is < 8, numDegrees rounds to 0 due to the int > > conversion

Re: Review Request: Dolphin zoom with CTRL+MouseWheel

2011-08-30 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102490/#review6174 --- dolphin/src/views/dolphinview.cpp

Review Request: Dolphin zoom with CTRL+MouseWheel

2011-08-30 Thread Vishesh Yadav
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102490/ --- Review request for KDE Base Apps and Peter Penz. Summary --- Zoom Dol

Re: Review Request: Dolphin zoom with CTRL+MouseWheel

2011-08-30 Thread Peter Penz
> On Aug. 30, 2011, 4:55 p.m., Dominik Haumann wrote: > > dolphin/src/views/dolphinview.cpp, line 691 > > > > > > Just a maybe: > > if event->delta() is < 8, numDegrees rounds to 0 due to the int > > conversion

Re: Review Request: Dolphin zoom with CTRL+MouseWheel

2011-08-30 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102490/#review6167 --- Ship it! Thanks, this is a good idea :-) I could not try the pa