Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-04-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/#review12195 --- This review has been submitted with commit 57c3f0c7b40c8d3aaee

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-18 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/#review10720 --- Ship it! You may consider to add checking also CMAKE_C_IMPLICI

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-18 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/#review10718 --- Ship it! Ignore what I said before, the patch is the right thi

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-18 Thread Alexander Neundorf
On Saturday 18 February 2012, Modestas Vainius wrote: > > On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > > Actually this looks more like a cmake bug, the contents of > > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. What > > > version of cmake are you using ? > > >

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-18 Thread Modestas Vainius
> On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > Actually this looks more like a cmake bug, the contents of > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. > > What version of cmake are you using ? > > > > Felix Geyer wrote: > 2.8.5 (with this commit cerry-p

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-08 Thread Alexander Neundorf
On Wednesday 08 February 2012, Rex Dieter wrote: > > On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > > Actually this looks more like a cmake bug, the contents of > > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. What > > > version of cmake are you using ? > > > > Fe

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-08 Thread Rex Dieter
> On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > Actually this looks more like a cmake bug, the contents of > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. > > What version of cmake are you using ? > > > > Felix Geyer wrote: > 2.8.5 (with this commit cerry-p

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-08 Thread Rex Dieter
> On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > Actually this looks more like a cmake bug, the contents of > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. > > What version of cmake are you using ? > > > > Felix Geyer wrote: > 2.8.5 (with this commit cerry-p

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2011-12-16 Thread Felix Geyer
> On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > Actually this looks more like a cmake bug, the contents of > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. > > What version of cmake are you using ? > > 2.8.5 (with this commit cerry-picked: http://cmake.org/gitw

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2011-12-16 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/#review9012 --- Actually this looks more like a cmake bug, the contents of CMAK

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2011-12-16 Thread Felix Geyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/ --- (Updated Dec. 16, 2011, 8:41 a.m.) Review request for kdelibs and Alexande

Review Request: Don't set an RPATH when installed into multiarch dir

2011-12-15 Thread Felix Geyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/ --- Review request for kdelibs. Description --- Don't set an RPATH when i