Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review10149 --- This review has been submitted with commit 73f5e4716fcb760b3a9

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review9767 --- This review has been submitted with commit 3c870e7d094c96afa322

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-09 Thread Johannes Huber
> On Jan. 9, 2012, 9:24 p.m., Alexander Neundorf wrote: > > Looks good now. Note i cant ship it by myself, have no developer application. - Johannes --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-09 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review9676 --- Ship it! Looks good now. - Alexander Neundorf On Jan. 8, 201

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-08 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/ --- (Updated Jan. 8, 2012, 4:35 p.m.) Review request for kdelibs. Changes --

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-06 Thread Alexander Neundorf
On Friday 06 January 2012, Rolf Eike Beer wrote: > > - remove the if(WIN32) > > around the pkgconfig-stuff. People say it should work also on Windows. So > > let's see. > > But add an if() to check if pkg-config is actually found? If it's not found, the call to the macro simply does not set any v

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-06 Thread Rolf Eike Beer
> - remove the if(WIN32) > around the pkgconfig-stuff. People say it should work also on Windows. So > let's see. But add an if() to check if pkg-config is actually found? signature.asc Description: This is a digitally signed message part.

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-06 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review9616 --- We're getting there :-) ...but not yet completely. You actually

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-06 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/ --- (Updated Jan. 6, 2012, 1:06 p.m.) Review request for kdelibs. Changes --

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-05 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review9583 --- As I said, whuile you're at it, please try to parse the version

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-05 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/ --- (Updated Jan. 5, 2012, 5:41 p.m.) Review request for kdelibs. Changes --

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-05 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review9582 --- Please don't commit it. As others have said, if you use pkg-con

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-05 Thread Andreas Pakulat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review9569 --- Like Eike said, use the PkgConfig module with pkg-config. For a

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-05 Thread Rolf Eike Beer
> > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103631/ > --- > > Review request for kdelibs. If it is a CMake-related issue it's

Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-05 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/ --- Review request for kdelibs. Description --- This is a gentoo downstre