Re: Review Request: Fix KIO listDir entries batching

2012-12-07 Thread Mark Gaiser
> On Dec. 6, 2012, 9:15 p.m., Mark Gaiser wrote: > > Do i also need to push this to the frameworks branch? If so, how? > > git checkout KDE/frameworks > > git pull > > git checkout > > git rebase KDE/frameworks > > git checkout KDE/frameworks > > git merge > > git push > > > > Just verifying i

Re: Review Request: Fix KIO listDir entries batching

2012-12-06 Thread Christoph Feck
> On Dec. 6, 2012, 9:15 p.m., Mark Gaiser wrote: > > Do i also need to push this to the frameworks branch? If so, how? > > git checkout KDE/frameworks > > git pull > > git checkout > > git rebase KDE/frameworks > > git checkout KDE/frameworks > > git merge > > git push > > > > Just verifying i

Re: Review Request: Fix KIO listDir entries batching

2012-12-06 Thread Mark Gaiser
> On Dec. 6, 2012, 9:15 p.m., Mark Gaiser wrote: > > Do i also need to push this to the frameworks branch? If so, how? > > git checkout KDE/frameworks > > git pull > > git checkout > > git rebase KDE/frameworks > > git checkout KDE/frameworks > > git merge > > git push > > > > Just verifying i

Re: Review Request: Fix KIO listDir entries batching

2012-12-06 Thread David Faure
> On Dec. 6, 2012, 9:15 p.m., Mark Gaiser wrote: > > Do i also need to push this to the frameworks branch? If so, how? > > git checkout KDE/frameworks > > git pull > > git checkout > > git rebase KDE/frameworks > > git checkout KDE/frameworks > > git merge > > git push > > > > Just verifying i

Re: Review Request: Fix KIO listDir entries batching

2012-12-06 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/#review23096 --- Do i also need to push this to the frameworks branch? If so, ho

Re: Review Request: Fix KIO listDir entries batching

2012-12-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/#review23095 --- This review has been submitted with commit 23ba25b6505dc7f46f8

Re: Review Request: Fix KIO listDir entries batching

2012-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/#review23060 --- Ship it! The code is a lot simpler, therefore this looks prett

Re: Review Request: Fix KIO listDir entries batching

2012-12-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/ --- (Updated Dec. 5, 2012, 6:54 p.m.) Review request for kdelibs and David Fau

Re: Review Request: Fix KIO listDir entries batching

2012-12-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/#review22962 --- kio/kio/slavebase.cpp

Re: Review Request: Fix KIO listDir entries batching

2012-12-03 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/#review22936 --- Any other comments on this? - Mark Gaiser On Nov. 29, 2012,

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/ --- (Updated Nov. 29, 2012, 11:10 p.m.) Review request for kdelibs and David F

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Mark Gaiser
> On Nov. 29, 2012, 7:48 p.m., Pino Toscano wrote: > > kioslave/file/file_unix.cpp, line 363 > > > > > > This would be QFile::decodeName, not QString::fromLocal8Bit... but you > > don't need it either, since you ha

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Pino Toscano
> On Nov. 29, 2012, 7:48 p.m., Pino Toscano wrote: > > kioslave/file/file_unix.cpp, line 363 > > > > > > This would be QFile::decodeName, not QString::fromLocal8Bit... but you > > don't need it either, since you ha

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Mark Gaiser
> On Nov. 29, 2012, 7:48 p.m., Pino Toscano wrote: > > kioslave/file/file_unix.cpp, line 363 > > > > > > This would be QFile::decodeName, not QString::fromLocal8Bit... but you > > don't need it either, since you ha

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/#review22785 --- kioslave/file/file_unix.cpp

Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/ --- Review request for kdelibs and David Faure. Description --- listDir i