Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-10 Thread David Faure
> On May 10, 2012, 8:38 a.m., David Faure wrote: > > As documented, the shortcut(types) method allows to retrieve either the > > current shortcuts (like most other methods), or the *default* shortcuts, > > i.e. those that were set by the application developer initially, before the > > user cou

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/#review13648 --- As documented, the shortcut(types) method allows to retrieve ei

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-09 Thread Mark Gaiser
> On May 9, 2012, 8:53 p.m., Michael Jansen wrote: > > Hate to break the news to you after all that work. But the exact same thing > > you have achieved with this patch could be achieved by using a QAction for > > the missing Shortcut. Or a KAction for that matter as long as it is not > > part

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-09 Thread Michael Jansen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/#review13624 --- Hate to break the news to you after all that work. But the exac

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-04 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/#review13436 --- Any re-review on this? - Mark Gaiser On May 2, 2012, 6:19 p.

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/ --- (Updated May 2, 2012, 6:19 p.m.) Review request for kdelibs. Changes ---

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-01 Thread Michael Jansen
On Tuesday, May 01, 2012 06:05:01 PM Mark Gaiser wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/ On April 30th, 2012, 10:19 p.m., David Faure wrote: I am in favour of the idea, since I was hit by this limitation in the past, too. H

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-01 Thread Mark Gaiser
> On April 30, 2012, 10:19 p.m., David Faure wrote: > > I am in favour of the idea, since I was hit by this limitation in the past, > > too. > > However I think the API changes should be more conservative, there's no > > need to deprecate so many of the existing methods, just because it is > >

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-04-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/#review13178 --- I am in favour of the idea, since I was hit by this limitation