Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/ --- Review request for kdelibs and Plasma. Description --- This is patch

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review9078 --- kdeui/kernel/kglobalsettings.cpp

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque Vieira Souza
> On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > kdeui/kernel/kglobalsettings.cpp, line 886 > > > > > > I like the idea (KGlobalSettings reparsing configuration), but not the > > implementation (setLanguage(la

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > > kdeui/kernel/kglobalsettings.cpp, line 886 > > > > > e886>> > > > > I like the idea (KGlobalSett

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque V. Souza
Em Monday 19 December 2011, David Faure escreveu: > On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: > > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > > > kdeui/kernel/kglobalsettings.cpp, line 886 > > > >

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
On Monday 19 December 2011 15:01:51 Lamarque V. Souza wrote: > Em Monday 19 December 2011, David Faure escreveu: > > On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: > > > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > > > > kdeui/kernel/kglobalsettings.cpp, line 886 > > > >

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque V. Souza
Em Monday 19 December 2011, David Faure escreveu: > On Monday 19 December 2011 15:01:51 Lamarque V. Souza wrote: > > Em Monday 19 December 2011, David Faure escreveu: > > > On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: > > > > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > >

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/ --- (Updated Dec. 19, 2011, 10:15 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-26 Thread Lamarque V. Souza
Hi all, Can I submit the review below? By the way, is kdelibs still closed to pushes? Em Monday 19 December 2011, Lamarque Vieira Souza escreveu: > --- > This is an automatically generated e-mail. To reply, visit: > http://g

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review9300 --- This review has been submitted with commit 7bc79dbefc2f52f92657

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review9292 --- Ship it! Looks good. You can commit to kdelibs, branch KDE/4.8

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review10141 --- This review has been submitted with commit 87756493f51716594c5