Re: Review Request: PATCH: Change the default KIO USERAGENT string.

2011-05-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101337/#review3413 --- This review has been submitted with commit e2d70d6c478c1f82f065

Re: Review Request: PATCH: Change the default KIO USERAGENT string.

2011-05-11 Thread Dawit Alemayehu
> On May 11, 2011, 4:19 p.m., Alex Merry wrote: > > kio/kio/kprotocolmanager.cpp, line 350 > > > > > > Wouldn't asyncCall be better, since we don't care about the reply? Or > > just pass QDBus::NoBlock to call().

Re: Review Request: PATCH: Change the default KIO USERAGENT string.

2011-05-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101337/#review3262 --- I don't know much about the code, just noticed a couple of thing

Review Request: PATCH: Change the default KIO USERAGENT string.

2011-05-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101337/ --- Review request for kdelibs. Summary --- This patch changes the defaul