Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-09 Thread Thomas Lübking
On Aug. 8, 2011, 10:51 p.m., David Jarvie wrote: If the proposed patch is unacceptable, I suggest adding a new method static void allowWindowModal(bool allow); If called with true, this would enable the behaviour described in the apidocs for subsequent KMessageBox instances. By

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-09 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/ --- (Updated Aug. 9, 2011, 8:39 a.m.) Review request for kdelibs. Changes

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/#review5532 --- API looks ok. Implementation could prevent duplication by

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/#review5537 --- This review has been submitted with commit

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-08 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/#review5492 --- Looks like the sumilar issur in Qt:

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-08 Thread Thomas Zander
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/#review5517 --- This change could alter the behaviour of some windows, if they

Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-07 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/ --- Review request for kdelibs. Summary --- According to the apidocs,