Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102802/ --- Review request for KDE Base Apps. Description --- This patch complete

Re: Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102802/#review7304 --- Nice, work, as always :) Only one question: Do the port spin box

Re: Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-13 Thread Dawit Alemayehu
> On Oct. 14, 2011, 12:05 a.m., Christoph Feck wrote: > > Nice, work, as always :) Only one question: Do the port spin boxes need the > > "Port:" labels, as seen in the ASCII drawings from bug 147340? Or would it > > clutter the interface? Maybe a "Hostname" and "Port" headline for the two > >

Re: Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102802/ --- (Updated Oct. 14, 2011, 5:32 a.m.) Review request for KDE Base Apps. Cha

Re: Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-14 Thread Jonathan Marten
> On Oct. 14, 2011, 12:05 a.m., Christoph Feck wrote: > > Nice, work, as always :) Only one question: Do the port spin boxes need the > > "Port:" labels, as seen in the ASCII drawings from bug 147340? Or would it > > clutter the interface? Maybe a "Hostname" and "Port" headline for the two > >

Re: Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-14 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102802/ --- (Updated Oct. 14, 2011, 8:38 p.m.) Review request for KDE Base Apps. Des

Re: Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-17 Thread Dawit Alemayehu
> On Oct. 14, 2011, 12:05 a.m., Christoph Feck wrote: > > Nice, work, as always :) Only one question: Do the port spin boxes need the > > "Port:" labels, as seen in the ASCII drawings from bug 147340? Or would it > > clutter the interface? Maybe a "Hostname" and "Port" headline for the two > >

Re: Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-17 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102802/ --- (Updated Oct. 18, 2011, 6:53 a.m.) Review request for KDE Base Apps. Cha