Review Request: Reset time format upon user request

2011-12-16 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/ --- Review request for kdelibs and Plasma. Description --- The patch rese

Re: Review Request: Reset time format upon user request

2011-12-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9018 --- i've made it so that kcmlocale also emit the signal ... now we j

Re: Review Request: Reset time format upon user request

2011-12-16 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/ --- (Updated Dec. 16, 2011, 9:13 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: Reset time format upon user request

2011-12-18 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9030 --- Ship it! i'm ok with this fix for now, but we need to look at m

Re: Review Request: Reset time format upon user request

2011-12-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9031 --- SETTINGS_COMPLETION !? This has nothing to do with completion. H

Re: Review Request: Reset time format upon user request

2011-12-18 Thread Lamarque Vieira Souza
> On Dec. 18, 2011, 8:33 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/digital-clock/clock.cpp, lines 100-102 > > > > > > this still realy ought to be done in klocale Well, we could add a KLocale::commit()

Re: Review Request: Reset time format upon user request

2011-12-18 Thread Lamarque Vieira Souza
> On Dec. 18, 2011, 8:59 a.m., David Faure wrote: > > SETTINGS_COMPLETION !? This has nothing to do with completion. How about > > adding a SETTINGS_LOCALE if that's what you need? I am trying to minimize the number of patches needed to fix bug #289094. This review is patch number two and a th

Re: Review Request: Reset time format upon user request

2011-12-18 Thread David Faure
On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote: > Another problem with this approach is that we cannot prevent anybody else > from listening to > KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, > KGlobalSettings::SETTING_LOCALE). What would be wrong with that

Re: Review Request: Reset time format upon user request

2011-12-18 Thread Lamarque V. Souza
Em Sunday 18 December 2011, David Faure escreveu: > On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote: > > Another problem with this approach is that we cannot prevent anybody else > > from listening to > > KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, > > KGlo

Re: Review Request: Reset time format upon user request

2011-12-19 Thread David Faure
On Sunday 18 December 2011 20:26:42 Lamarque V. Souza wrote: > Em Sunday 18 December 2011, David Faure escreveu: > > On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote: > > > Another problem with this approach is that we cannot prevent anybody > > > else > > > from listening to > > > K

Re: Review Request: Reset time format upon user request

2011-12-19 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/ --- (Updated Dec. 19, 2011, 2:03 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: Reset time format upon user request

2011-12-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9163 --- This review has been submitted with commit 68ec5f077e20afe09def

Re: Review Request: Reset time format upon user request

2011-12-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9302 --- This review has been submitted with commit 8bd86323cdbd11ffafb7