Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17085 --- This review has been submitted with commit c578e8804ee6505ea28

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17084 --- This review has been submitted with commit 0af24b2dcd32fd74f1a

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17060 --- This review has been submitted with commit b8e506743429fa28694

Re: Review Request: Support for GRUB2 submenus

> On Aug. 7, 2012, 4:42 p.m., Oswald Buddenhagen wrote: > > Ship It! > > Konstantinos Smanis wrote: > What should I commit to which branches? 4.8.5 is out, so any commits in > the 4.8.x branch won't ever be officially released. I guess the kdm part can > affect all the rest (4.9.x, master)

Re: Review Request: Support for GRUB2 submenus

> On Aug. 7, 2012, 4:42 p.m., Oswald Buddenhagen wrote: > > Ship It! What should I commit to which branches? 4.8.5 is out, so any commits in the 4.8.x branch won't ever be officially released. I guess the kdm part can affect all the rest (4.9.x, master) branches. - Konstantinos ---

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17055 --- Ship it! Ship It! - Oswald Buddenhagen On Aug. 7, 2012, 3:5

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 7, 2012, 3:56 p.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

> On Aug. 7, 2012, 1:25 p.m., Oswald Buddenhagen wrote: > > kdm/backend/util.c, line 205 > > > > > > len isn't actually used in that loop > > Konstantinos Smanis wrote: > It is used, it counts the occurences o

Re: Review Request: Support for GRUB2 submenus

> On Aug. 7, 2012, 1:25 p.m., Oswald Buddenhagen wrote: > > kdm/backend/util.c, line 205 > > > > > > len isn't actually used in that loop It is used, it counts the occurences of before in str. This is countSubstr(

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 7, 2012, 1:37 p.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17032 --- kdm/backend/util.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 7, 2012, 9:20 a.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17015 --- looking excellent now. just some style issues left. please wri

Re: Review Request: Support for GRUB2 submenus

> On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 232 > > > > > > can be inlined into the caller > On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdow

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 6, 2012, 6:29 p.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

> On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 488 > > > > > > as you make assumptions about the list structure below anyway, you can > > just make the menus a stack (t

Re: Review Request: Support for GRUB2 submenus

> On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 488 > > > > > > as you make assumptions about the list structure below anyway, you can > > just make the menus a stack (t

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16926 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 5, 2012, 1:25 p.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 5, 2012, 12:39 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On Aug. 1, 2012, 6:25 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 485 > > > > > > why do you do that? the non-nested case should be just the simple > > solution of the general nested case

Re: Review Request: Support for GRUB2 submenus

> On Aug. 1, 2012, 6:25 a.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 239 > > > > > > this implementation is very clever, but i wonder whether it wouldn't be > > better to do something more conve

Re: Review Request: Support for GRUB2 submenus

> On Aug. 1, 2012, 11:49 a.m., Konstantinos Smanis wrote: > > Btw I see that they have bumped the version to 4.8.5 (no tag yet). Maybe we > > should drop the ksmserver part? It doesn't apply on the 4.9 branch. > > Lamarque Vieira Souza wrote: > We still need to port the part that deals with

Re: Review Request: Support for GRUB2 submenus

> On Aug. 1, 2012, 11:49 a.m., Konstantinos Smanis wrote: > > Btw I see that they have bumped the version to 4.8.5 (no tag yet). Maybe we > > should drop the ksmserver part? It doesn't apply on the 4.9 branch. We still need to port the part that deals with submenu separator to ksmserver 4.9.x.

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16753 --- Btw I see that they have bumped the version to 4.8.5 (no tag ye

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 1, 2012, 8:54 a.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

> On Aug. 1, 2012, 6:25 a.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > > > > > > this function must come with a huge warning that strlen(after) must be > > at most strlen(before) - otherwise

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16732 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16723 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

> On July 31, 2012, 7:17 p.m., Lamarque Vieira Souza wrote: > > kdm/backend/bootman.c, line 269 > > > > > > "const char *sep;" just declares a pointer called sep, it does not > > allocate memory to store any char

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16719 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

> On July 31, 2012, 6:39 p.m., Lamarque Vieira Souza wrote: > > kdm/backend/bootman.c, line 269 > > > > > > I think the memory for *sep has not been allocated yet at this point, > > so you should use something lik

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16717 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16710 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 31, 2012, 5:54 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16707 --- Argh, the last 2 diffs suck. Will update soon! - Konstantinos

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 30, 2012, 12:31 p.m.) Review request for KDE Runtime and Osw

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 30, 2012, 12:06 a.m.) Review request for KDE Runtime and Osw

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 10:53 p.m.) Review request for KDE Runtime and Osw

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 8:30 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 29, 2012, 7:09 p.m., Oswald Buddenhagen wrote: > > looks okayish. you should attack the bigger issues now. ;) Maybe tomorrow (unless I have a post-midnight coding mood). > On July 29, 2012, 7:09 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 287 > >

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16624 --- looks okayish. you should attack the bigger issues now. ;) kd

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 7:05 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 29, 2012, 6:56 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 288 > > > > > > as this is a constant, you could use stringify() and literal > > concatenation - "foo" stringify(bar) "baz".

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16619 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 6:50 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 29, 2012, 6:18 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 232 > > > > > > oh horrors :D > > please change that to an else-if and just decrement here. I had to try and sneak this :

Re: Review Request: Support for GRUB2 submenus

> On July 29, 2012, 6:21 p.m., Lamarque Vieira Souza wrote: > > kdm/backend/bootman.c, line 268 > > > > > > Maybe you should print a kWarning() saying that we only support up to 5 > > submenu levels. good point. b

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16616 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16614 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 6:06 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > > > > > > you don't seem to be actually counting opening braces, so detaching the > > two counts makes little sense. >

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 11:58 a.m.) Review request for KDE Runtime and Osw

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > > > > > > you don't seem to be actually counting opening braces, so detaching the > > two counts makes little sense. >

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > tired or not ... Please check my replies. I will update the diff tomorrow. > On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > >

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 17, 2012, 10 p.m.) Review request for KDE Runtime and Oswald

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 9:02 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 280 > > > > > > i have a deep dislike for the separator being just ">" - it's weirdness > > waiting to happen. use " >> " or

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 17, 2012, 9:23 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 5:33 p.m., Lamarque Vieira Souza wrote: > > Ship It! Should I commit this? The KDM maintainer hasn't replied yet. Plus, will the 4.8 branch get the fix eventually? Noone else has commented... - Konstantinos --- This

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16042 --- tired or not ... kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16037 --- one profound concern and some style nitpicks. i didn't look at

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 5:33 p.m., Lamarque Vieira Souza wrote: > > Ship It! > > Konstantinos Smanis wrote: > Should I commit this? The KDM maintainer hasn't replied yet. Plus, will > the 4.8 branch get the fix eventually? Noone else has commented... I am giving my oppinion about the patch (sh

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16017 --- Ship it! Ship It! - Lamarque Vieira Souza On July 14, 2012,

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review15855 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 14, 2012, 8:16 a.m.) Review request for KDE Runtime and Oswa