Re: Review Request: kjs: Implement JSON.parse

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review18561 --- This review has been submitted with commit ae94e9a23275611e1c3

Re: Review Request: kjs: Implement JSON.parse

2012-07-22 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review16241 --- Ship it! Ship It! - Maks Orlovich On July 6, 2012, 7:11 p.m

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 6, 2012, 7:11 p.m.) Review request for kdelibs. Descriptio

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Bernd Buschinski
> On July 6, 2012, 3:12 p.m., Maks Orlovich wrote: > > kjs/jsonlexer.cpp, line 309 > > > > > > What about two commas in a row? propAdded handles this (tested), we will hit the TokComma case 2 times in a row case

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15462 --- kjs/jsonlexer.cpp

Re: Review Request: kjs: Implement JSON.parse

2012-07-05 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 5, 2012, 12:50 p.m.) Review request for kdelibs. Changes -

Re: Review Request: kjs: Implement JSON.parse

2012-07-05 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 5, 2012, 12:35 p.m.) Review request for kdelibs. Descripti

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15397 --- No functional review, just reading through the code. kjs/json

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 4, 2012, 10:27 p.m.) Review request for kdelibs. Changes -

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Bernd Buschinski
> On July 4, 2012, 2:24 p.m., Maks Orlovich wrote: > > kjs/jsonlexer.cpp, line 198 > > > > > > I don't think this is needed anymore. If we got called from JSONArray-TokLBrace we did not create an object. In more d

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15374 --- kjs/json_object.cpp

Re: Review Request: kjs: Implement JSON.parse

2012-06-18 Thread Bernd Buschinski
> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote: > > kjs/json_object.cpp, line 37 > > > > > > What namespace do the symbols for this end up in? > > like all other generated luts, in the KJS namespace > On June

Re: Review Request: kjs: Implement JSON.parse

2012-06-18 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated June 18, 2012, 10:25 p.m.) Review request for kdelibs. Changes

Re: Review Request: kjs: Implement JSON.parse

2012-06-10 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review14590 --- kjs/json_object.cpp

Re: Review Request: kjs: Implement JSON.parse

2012-05-28 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated May 28, 2012, 7:52 p.m.) Review request for kdelibs. Changes --

Re: Review Request: kjs: Implement JSON.parse

2012-05-28 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review14235 --- kjs/json_object.cpp

Re: Review Request: kjs: Implement JSON.parse

2012-05-27 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated May 27, 2012, 3:30 p.m.) Review request for kdelibs. Changes --

Re: Review Request: kjs: Implement JSON.parse

2012-05-26 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review14177 --- You forgot to change kjs/tests/ecmatest_broken_* - Rolf Eike B

Review Request: kjs: Implement JSON.parse

2012-05-25 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- Review request for kdelibs. Description --- kjs: Implement JSON.parse