Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-25 Thread Askar Safin
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-25 Thread David Faure
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-25 Thread Askar Safin
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-25 Thread Askar Safin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Dec. 25, 2011, 9:01 a.m.) Review request for kdelibs and Konsole.

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Thomas Lübking
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Askar Safin
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Askar Safin
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Thomas Lübking
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread David Faure
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Thomas Lübking
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread David Faure
> On Dec. 23, 2011, 11:59 a.m., Askar Safin wrote: > > Ship It! I don't think you're supposed to "Ship it" your own change, the point of reviewboard is to get reviews from others :-) - David --- This is an automatically generated e-mai

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review9226 --- This seems like a dangerous change to me. With it, you could ru

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-23 Thread Askar Safin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review9200 --- Ship it! Ship It! - Askar Safin On Dec. 23, 2011, 11:58 a.m.

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-23 Thread Askar Safin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Dec. 23, 2011, 11:58 a.m.) Review request for kdelibs. Summary