Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102869/ --- Review request for kdelibs. Description --- Only install CMakeParseAr

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102869/#review7375 --- Please don't commit this. This is on purpose. We install a file

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Ralf Jung
> On Oct. 16, 2011, 9:43 a.m., Alexander Neundorf wrote: > > Please don't commit this. > > This is on purpose. > > We install a file which includes CMakeParseArguments.cmake, so we *must* > > also install CMakeParseArguments.cmake itself, otherwise we may get in > > trouble if the version in cm

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Alexander Neundorf
On Sunday 16 October 2011, Ralf Jung wrote: > > On Oct. 16, 2011, 9:43 a.m., Alexander Neundorf wrote: > > > Please don't commit this. > > > This is on purpose. > > > We install a file which includes CMakeParseArguments.cmake, so we > > > *must* also install CMakeParseArguments.cmake itself, otherw

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Ralf Jung
Hi, > > The problem is that this results in a warning about CMake files being > > overridden when running cmake for kde-workspace. > > Can you post the exact warning message here, please ? Sure, here it is: CMake Warning (dev) at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-16 Thread Alexander Neundorf
On Sunday 16 October 2011, Ralf Jung wrote: > Hi, > > > > The problem is that this results in a warning about CMake files being > > > overridden when running cmake for kde-workspace. > > > > Can you post the exact warning message here, please ? > > Sure, here it is: > CMake Warning (dev) at > /u

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-23 Thread Ralf Jung
Hi, > That's the problem. > CMP0017 should be set to NEW, and it is set to NEW in > FindKDE4Internal.cmake. So we need to find out why it is not set in this > case. Thanks for this hint! After some more debugging, I came up with attached patch against kde-workspace which also fixes the warning he

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-23 Thread Alexander Neundorf
On Sunday 23 October 2011, Ralf Jung wrote: > Hi, > > > That's the problem. > > CMP0017 should be set to NEW, and it is set to NEW in > > FindKDE4Internal.cmake. So we need to find out why it is not set in this > > case. > > Thanks for this hint! After some more debugging, I came up with attached

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-24 Thread Ralf Jung
Hi, > Yes, most probably. > > > I guess it was first developed as a standalone tool, where you have to do > everything yourself, including searching for Qt4 etc., and then was added > into kdebase. Checking the other cmake files of libkephal, it does not seem to support standalone builds anymor

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-10-24 Thread Alexander Neundorf
On Monday 24 October 2011, Ralf Jung wrote: > Hi, > > > Yes, most probably. > > > > > > I guess it was first developed as a standalone tool, where you have to do > > everything yourself, including searching for Qt4 etc., and then was added > > into kdebase. > > Checking the other cmake files of

Re: Review Request: only install CMakeParseArguments.cmake for cmake versions that do not have it

2011-11-07 Thread Ralf Jung
> On Oct. 16, 2011, 9:43 a.m., Alexander Neundorf wrote: > > Please don't commit this. > > This is on purpose. > > We install a file which includes CMakeParseArguments.cmake, so we *must* > > also install CMakeParseArguments.cmake itself, otherwise we may get in > > trouble if the version in cm