Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31469 --- plasma/private/dialogshadows.cpp

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated April 27, 2013, 7:16 a.m.) Review request for kdelibs, Aaron J. S

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31652 --- plasma/private/dialogshadows.cpp

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated April 27, 2013, 11:01 a.m.) Review request for kdelibs, Aaron J.

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

> On April 27, 2013, 10:40 a.m., Thomas Lübking wrote: > > that part of patch comes from here i think : https://git.reviewboard.kde.org/r/110029/ ( it was marked as ship it ) [i will wait until it commits than i will send my part. But if you think there is a strange behavior on that clearPixma

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

> On April 27, 2013, 7:40 a.m., Thomas Lübking wrote: > > plasma/private/dialogshadows.cpp, line 371 > > > > > > this looks slightly like a recursion? > > (i think void DialogShadows::Private::freeX11Pixmaps()

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

> On April 27, 2013, 10:40 a.m., Thomas Lübking wrote: > > plasma/private/dialogshadows.cpp, line 371 > > > > > > this looks slightly like a recursion? > > (i think void DialogShadows::Private::freeX11Pixmaps(

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated April 27, 2013, 12:04 p.m.) Review request for kdelibs, Aaron J.

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated April 30, 2013, 12:04 p.m.) Review request for kdelibs, Aaron J.

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31809 --- Ship it! Ship It! - Aaron J. Seigo On April 30, 2013, 9:04

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31830 --- This review has been submitted with commit ebca90e1a50435f27cb

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated May 1, 2013, 10:53 a.m.) Status -- This change has been mark