Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 19, 2013, 7:35 p.m.) Status -- This change has been mar

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review34706 --- This review has been submitted with commit cd2c23ee59461cfe4f7

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-17 Thread Mark Gaiser
> On June 16, 2013, 8:52 p.m., Fredrik Höglund wrote: > > Looks good to me. > > > > Maksim Orlovich suggested that we should look into using lossless WebP for > > images in KDE, > > since WebP has faster decompression than libpng, and produces smaller files. > > > > I've done some tests with O

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-16 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review34447 --- Ship it! Looks good to me. Maksim Orlovich suggested that we

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-16 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated June 16, 2013, 11:58 a.m.) Review request for KDE Runtime. Chan

Re: Review Request 110649: add kimgio WebP image format plugin

2013-05-30 Thread Fredrik Höglund
> On May 26, 2013, 2:15 p.m., Fredrik Höglund wrote: > > kimgio/webp.cpp, line 58 > > > > > > This is not particularly efficient. WebPDecodeBGRAInto() can decode > > directly into a QImage without using an interme

Re: Review Request 110649: add kimgio WebP image format plugin

2013-05-30 Thread Martin Koller
> On May 26, 2013, 6:45 p.m., Albert Astals Cid wrote: > > How is this hooked up to the rest of kde-runtime? The patch missed the diff of the CMakeLists.txt file from kde-runtime directly. I'll upload a new diff - Martin --- This is an

Re: Review Request 110649: add kimgio WebP image format plugin

2013-05-30 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated May 30, 2013, 10:11 a.m.) Review request for KDE Runtime. Chang

Re: Review Request 110649: add kimgio WebP image format plugin

2013-05-30 Thread Martin Koller
> On May 26, 2013, 2:15 p.m., Fredrik Höglund wrote: > > kimgio/webp.cpp, line 58 > > > > > > This is not particularly efficient. WebPDecodeBGRAInto() can decode > > directly into a QImage without using an interme

Re: Review Request 110649: add kimgio WebP image format plugin

2013-05-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review33167 --- How is this hooked up to the rest of kde-runtime? - Albert Ast

Re: Review Request 110649: add kimgio WebP image format plugin

2013-05-26 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/#review33153 --- kimgio/webp.cpp

Re: Review Request 110649: add kimgio WebP image format plugin

2013-05-26 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- (Updated May 26, 2013, 12:20 p.m.) Review request for KDE Runtime. Descr

Review Request 110649: add kimgio WebP image format plugin

2013-05-26 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110649/ --- Review request for KDE Runtime. Description --- This patch adds suppo