Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/ --- (Updated June 14, 2013, 8:24 p.m.) Status -- This change has been mar

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/#review34372 --- This review has been submitted with commit 52644b44e95bcf5e5c8

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-12 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/ --- (Updated June 12, 2013, 6:54 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-11 Thread Rex Dieter
> On June 11, 2013, 4:12 p.m., Rex Dieter wrote: > > Note too: this patch adds 2 new build dependencies, dbus-devel (aka dbus > > pkgconfig file: dbus-1.pc) and accountsservice itself (owner of the xml > > interface files) and, unfortunately, qdbusxml2cpp doesn't like /usr/share/dbus-1/interf

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-11 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/#review34154 --- Note too: this patch adds 2 new build dependencies, dbus-devel

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-10 Thread Greg T
> On June 9, 2013, 2:30 p.m., David Edmundson wrote: > > kdepasswd/kcm/main.cpp, line 251 > > > > > > This might not be right. > > > > With an empty pixmap in the image you call > > uinterface->SetIco

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-10 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/ --- (Updated June 10, 2013, 4:58 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/#review33926 --- Ship it! Few minor comments. kdepasswd/kcm/main.cpp

Review Request 110875: kcm_useraccount: support accountsservice

2013-06-07 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/ --- Review request for KDE Base Apps. Description --- save image file wit