Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-10-27 Thread Johannes Obermayr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111042/ --- (Updated Oct. 27, 2013, 6:51 p.m.) Status -- This change has been dis

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-07-01 Thread Luca Beltrame
In data domenica 30 giugno 2013 15:44:50, Johannes Obermayr ha scritto: > Why don't you drop obsolete patches and waste binaries then? You're welcome to join the discussion in the relevant downstream mailing list, discussion started months ago. This does not however concern KDE. > remove it). T

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-30 Thread Thomas Lübking
> On June 15, 2013, 5:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-30 Thread Johannes Obermayr
> On June 15, 2013, 7:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-16 Thread Luca Beltrame
> On June 15, 2013, 5:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-16 Thread Martin Gräßlin
> On June 15, 2013, 7:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-15 Thread Johannes Obermayr
> On June 15, 2013, 7:06 p.m., Albert Astals Cid wrote: > > Is this some kind of joke? > > > > Honestly upstreaming patches is good, but when they make sense, and adding > > billions of "If #SUSE" to our code does not make any sense. Please discard > > this review, break stuff in separate patc

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-15 Thread Luca Beltrame
> On June 15, 2013, 6:52 p.m., Luca Beltrame wrote: > > I would like to chime in, since I'm also a member of the openSUSE community > > KDE team. This patch and the idea behind it is *not* the official position > > of openSUSE, nor the official position of the openSUSE community KDE team. > >

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-15 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111042/#review34392 --- I would like to chime in, since I'm also a member of the openSU

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111042/#review34388 --- Is this some kind of joke? Honestly upstreaming patches is goo

Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-15 Thread Johannes Obermayr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111042/ --- Review request for kdelibs. Description --- Distributions should upst