Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/ --- (Updated June 23, 2013, 6:12 p.m.) Review request for kdelibs, David Faure

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34924 --- kdecore/services/kmimetype.cpp

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34926 --- > "KMimeTypePrivate::iconName" is now the one slowing everythin

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
> On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: > > > "KMimeTypePrivate::iconName" is now the one slowing everything down > > > mostly because of the QHash. > > Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix > > base and no variable costs - but it's slower on in

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
> On June 23, 2013, 6:29 p.m., Milian Wolff wrote: > > kdecore/services/kmimetype.cpp, line 376 > > > > > > unrelated change Well, i changed the function so i took the liberty of updating the code style for that

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/ --- (Updated June 23, 2013, 9:21 p.m.) Review request for kdelibs, David Faure

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
> On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: > > > "KMimeTypePrivate::iconName" is now the one slowing everything down > > > mostly because of the QHash. > > Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix > > base and no variable costs - but it's slower on in

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
> On June 23, 2013, 6:29 p.m., Milian Wolff wrote: > > kdecore/services/kmimetype.cpp, line 345 > > > > > > try using QStringRef here to safe allocations if you care about speed. > > Mark Gaiser wrote: > QStr

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
> On June 23, 2013, 6:29 p.m., Milian Wolff wrote: > > kdecore/services/kmimetype.cpp, line 376 > > > > > > unrelated change > > Mark Gaiser wrote: > Well, i changed the function so i took the liberty of upda

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Mark Gaiser
> On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: > > > "KMimeTypePrivate::iconName" is now the one slowing everything down > > > mostly because of the QHash. > > Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix > > base and no variable costs - but it's slower on in

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Thomas Lübking
> On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: > > > "KMimeTypePrivate::iconName" is now the one slowing everything down > > > mostly because of the QHash. > > Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix > > base and no variable costs - but it's slower on in

Re: Review Request 111050: Fast mime detection speedup.

2013-06-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34953 --- The test you should be running is kmimetypetest, not kurlmimety

Re: Review Request 111050: Fast mime detection speedup.

2013-06-30 Thread Mark Gaiser
> On June 24, 2013, 9:19 a.m., David Faure wrote: > > kdecore/services/kmimetype.cpp, line 316 > > > > > > I can't review this. It completely forks an existing method > > (findByUrlHelper), which is already suppo

Re: Review Request 111050: Fast mime detection speedup.

2013-06-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review35308 --- kdecore/services/kmimetype.cpp

Re: Review Request 111050: Fast mime detection speedup.

2013-06-30 Thread Alexander Neundorf
On Sunday 30 June 2013, Mark Gaiser wrote: > > On June 24, 2013, 9:19 a.m., David Faure wrote: > > > kdecore/services/kmimetype.cpp, line 316 > > > > > line316> > > > > > > I can't review this. It completely forks an exi

Re: Review Request 111050: Fast mime detection speedup.

2013-10-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review42488 --- Mark, David, what's the status of this? Are you going to work f

Re: Review Request 111050: Fast mime detection speedup.

2013-10-27 Thread Mark Gaiser
> On Oct. 27, 2013, 6:50 p.m., Albert Astals Cid wrote: > > Mark, David, what's the status of this? Are you going to work further on > > this or shall it be discarded not to clutter the kdelibs group review list? Yes, there would be "a" speedup by further tweaking this patch. But would it be w

Re: Review Request 111050: Fast mime detection speedup.

2013-10-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/ --- (Updated Oct. 27, 2013, 6:55 p.m.) Status -- This change has been dis

Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/ --- Review request for kdelibs, David Faure and Frank Reininghaus. Description

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34437 --- While speedup is certainly always great, this sounds dangerous

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Mark Gaiser
> On June 16, 2013, 4:59 p.m., Sven Brauch wrote: > > While speedup is certainly always great, this sounds dangerous to me: > > > > > I am getting an inconsistency. Using the unpatched fast mime detection on > > > a file like: "test.tar.gz" gets detected as > > > "application-x-compressed-tar"

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Sven Brauch
> On June 16, 2013, 4:59 p.m., Sven Brauch wrote: > > While speedup is certainly always great, this sounds dangerous to me: > > > > > I am getting an inconsistency. Using the unpatched fast mime detection on > > > a file like: "test.tar.gz" gets detected as > > > "application-x-compressed-tar"

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34443 --- Some comments on code. But I agree that this is too late for 4.

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34480 --- In addition to the issues below, I suspect it changes behavior

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34453 --- forgot to actually submit this yesterday... lets do it now even

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-21 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34805 --- Guys, thank you all very much for the thorough reviewing! Sorry