Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/#review35275 --- Ship it! Ship It! - Oswald Buddenhagen On June 28, 2013,

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread mr. mancha
On June 29, 2013, 11:37 a.m., Oswald Buddenhagen wrote: Ship It! Albert Astals Cid wrote: Mr Mancha Mancha we're going to need your real name and email before we can submit this for proper attribution. Hello Albert. For the purpose of attribution, my name is mancha (just once, not

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread Oswald Buddenhagen
On June 29, 2013, 11:37 a.m., Oswald Buddenhagen wrote: Ship It! Albert Astals Cid wrote: Mr Mancha Mancha we're going to need your real name and email before we can submit this for proper attribution. mr. mancha wrote: Hello Albert. For the purpose of attribution, my name

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/#review35291 --- This review has been submitted with commit

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-29 Thread Michael Pyne
On June 29, 2013, 8:31 p.m., Commit Hook wrote: This review has been submitted with commit 45b7f137fbc0b942fd2c9b4e8d8c1f0293e64ba7 by Michael Pyne to branch KDE/4.10. I have also pushed to master to fix for KDE 4.11. Commit 194da6154375fc8103b8c4e29e385cd7ae2e. Thanks for the

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-28 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/#review35196 --- kcheckpass/checkpass_osfc2passwd.c

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-28 Thread mancha mancha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/ --- (Updated June 28, 2013, 7:12 a.m.) Review request for kde-workspace.

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-28 Thread mancha mancha
On June 28, 2013, 6:20 a.m., Oswald Buddenhagen wrote: kdm/backend/client.c, line 545 http://git.reviewboard.kde.org/r/111261/diff/2/?file=166173#file166173line545 i really meant line 543. ;) just as the code using it, it must be in the else branch of PAM and AIX. This should

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-27 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/#review35158 --- kcheckpass/checkpass_etcpasswd.c

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-27 Thread mancha mancha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/ --- (Updated June 27, 2013, 6:05 p.m.) Review request for kde-workspace.

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-27 Thread mancha mancha
On June 27, 2013, 6:34 a.m., Oswald Buddenhagen wrote: kdm/backend/client.c, line 545 http://git.reviewboard.kde.org/r/111261/diff/1/?file=165919#file165919line545 there are countless #define combinations where this will cause unused variable warnings. follow the #ifdef cascade

Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-26 Thread mancha mancha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/ --- Review request for kde-workspace. Description --- Background: