Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-25 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ --- (Updated Aug. 25, 2013, 2:44 p.m.) Status -- This change has been dis

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-25 Thread Eike Hein
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Thomas Lübking
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Bhushan Shah
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Hrvoje Senjan
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Thomas Lübking
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Eike Hein
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Bhushan Shah
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: > > Hm, on the face of it, this patch doesn't really make sense ... launcher > > items don't have an associated task, so the function should already return > > early and the extra condition should be redundant. Unless there's a race > > condition

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/#review38481 --- Hm, on the face of it, this patch doesn't really make sense ...

Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ --- Review request for kde-workspace, Plasma and Eike Hein. Description --