Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: > > AUTOMOC: error: process for > /lo

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Martin Klapetek
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: > > AUTOMOC: error: process for > /lo

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Martin Klapetek
> On Nov. 15, 2013, 10:09 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 7ec8cf76bad0f16a2947eb6d5986af436a3bdc69 by Martin Klapetek to branch > > frameworks. Erm, sorry, wrong review number in the commit. - Martin --

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43784 --- This review has been submitted with commit 7ec8cf76bad0f16a294

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-13 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. Locally, I get this error: AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Nov. 12, 2013, 10:39 a.m.) Status -- This change has been ma

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43507 --- This review has been submitted with commit 53e8e439af2483c86b2

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-10 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43331 --- Ship it! Ship It! - John Layt On Oct. 22, 2013, 4:49 p.m.,

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43323 --- Ship it! OK. I only meant "don't remove existing code that mig

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-05 Thread Kevin Ottens
> On Nov. 4, 2013, 4:12 p.m., John Layt wrote: > > I've asked on the Qt Development list about Qt 5 Solaris support. I'm told > > it builds and works to some extent, and patches are welcome, but not > > without having been tested on a real Solaris build first, which I have no > > desire to do

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-04 Thread Martin Klapetek
> On Nov. 4, 2013, 4:12 p.m., John Layt wrote: > > I've asked on the Qt Development list about Qt 5 Solaris support. I'm told > > it builds and works to some extent, and patches are welcome, but not > > without having been tested on a real Solaris build first, which I have no > > desire to do

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-04 Thread John Layt
> On Nov. 4, 2013, 4:12 p.m., John Layt wrote: > > I've asked on the Qt Development list about Qt 5 Solaris support. I'm told > > it builds and works to some extent, and patches are welcome, but not > > without having been tested on a real Solaris build first, which I have no > > desire to do

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-04 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42961 --- I've asked on the Qt Development list about Qt 5 Solaris suppor

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42954 --- Looks OK to me, but I'd like John to give it a last look. - Ke

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-31 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42743 --- Ping, this seems forgotten :) - Martin Klapetek On Oct. 22,

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Fra

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-21 Thread John Layt
> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-21 Thread Martin Klapetek
> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-21 Thread David Faure
> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-20 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42017 --- ktimezoned/ktimezonedbase.h

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 18, 2013, 1 p.m.) Review request for KDE Runtime, KDE Framew

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 17, 2013, 9:13 p.m.) Review request for KDE Runtime, KDE Fra

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-17 Thread Martin Klapetek
> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-16 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review41816 --- Wow, there sure is a lot of code in there catering for all the

Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Rep

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 15, 2013, 8:09 p.m.) Review request for KDE Runtime, KDE Fra