On Oct. 31, 2013, 2:41 p.m., Frank Reininghaus wrote:
I see now that I have tried to put too much stuff into a single patch -
it's too hard to digest and to understand, and the number of possibilities
to modify different aspects of UDSEntry in a different way is just too
large for me
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/
---
(Updated Nov. 3, 2013, 7 p.m.)
Status
--
This change has been
On Oct. 31, 2013, 2:41 p.m., Frank Reininghaus wrote:
I see now that I have tried to put too much stuff into a single patch -
it's too hard to digest and to understand, and the number of possibilities
to modify different aspects of UDSEntry in a different way is just too
large for me
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42745
---
I see now that I have tried to put too much stuff into a
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/
---
(Updated Oct. 26, 2013, 5:56 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42330
---
(d) Use QVector::reserve to reserve the appropriate size for
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42327
---
Just some minor nitpicking that i can see.
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote:
Have you tried a naive implementation with a
std::vectorstd::pairKey,Value? You say that a typical use case has
eight entries; that's a very small number where a well-tuned vector could
easily beat the O(1) of QHash or the O(log n) of
On Oct. 21, 2013, 7:36 p.m., Mark Gaiser wrote:
Oh wow! When reading through the comments i was quite surprised to see a
question for me :)
A very nice discussion btw!
As for the benchmarking. It's actually already available in a testcase if
you want that:
On Oct. 21, 2013, 8:20 p.m., Milian Wolff wrote:
kio/kio/udsentry.cpp, line 240
http://git.reviewboard.kde.org/r/113355/diff/2/?file=204198#file204198line240
you still check that for every uds - does it make sense for any
fields besides the ones I listed in my previous comment?
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote:
Have you tried a naive implementation with a
std::vectorstd::pairKey,Value? You say that a typical use case has
eight entries; that's a very small number where a well-tuned vector could
easily beat the O(1) of QHash or the O(log n) of
On Oct. 21, 2013, 8:20 p.m., Milian Wolff wrote:
kio/kio/udsentry.cpp, line 240
http://git.reviewboard.kde.org/r/113355/diff/2/?file=204198#file204198line240
you still check that for every uds - does it make sense for any
fields besides the ones I listed in my previous comment?
On Oct. 21, 2013, 6:26 p.m., Jan Kundrát wrote:
Have you tried a naive implementation with a
std::vectorstd::pairKey,Value? You say that a typical use case has
eight entries; that's a very small number where a well-tuned vector could
easily beat the O(1) of QHash or the O(log n) of
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42058
---
coolio :)
kio/kio/udsentry.cpp
On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote:
kio/kio/udsentry.cpp, line 51
http://git.reviewboard.kde.org/r/113355/diff/1/?file=203549#file203549line51
have you tried with a QMap? It has a lower memory overhead than QHash.
And for few items (which is the case here, if I
On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote:
kio/kio/udsentry.cpp, line 51
http://git.reviewboard.kde.org/r/113355/diff/1/?file=203549#file203549line51
have you tried with a QMap? It has a lower memory overhead than QHash.
And for few items (which is the case here, if I
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42115
---
Have you tried a naive implementation with a
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42113
---
kio/kio/udsentry.cpp
On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote:
kio/kio/udsentry.cpp, line 51
http://git.reviewboard.kde.org/r/113355/diff/1/?file=203549#file203549line51
have you tried with a QMap? It has a lower memory overhead than QHash.
And for few items (which is the case here, if I
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote:
Have you tried a naive implementation with a
std::vectorstd::pairKey,Value? You say that a typical use case has
eight entries; that's a very small number where a well-tuned vector could
easily beat the O(1) of QHash or the O(log n) of
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/
---
(Updated Oct. 21, 2013, 6:23 p.m.)
Review request for kdelibs.
Changes
On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote:
kio/kio/udsentry.cpp, line 51
http://git.reviewboard.kde.org/r/113355/diff/1/?file=203549#file203549line51
have you tried with a QMap? It has a lower memory overhead than QHash.
And for few items (which is the case here, if I
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote:
Have you tried a naive implementation with a
std::vectorstd::pairKey,Value? You say that a typical use case has
eight entries; that's a very small number where a well-tuned vector could
easily beat the O(1) of QHash or the O(log n) of
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote:
Have you tried a naive implementation with a
std::vectorstd::pairKey,Value? You say that a typical use case has
eight entries; that's a very small number where a well-tuned vector could
easily beat the O(1) of QHash or the O(log n) of
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42128
---
Oh wow! When reading through the comments i was quite
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42133
---
kio/kio/udsentry.cpp
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote:
Have you tried a naive implementation with a
std::vectorstd::pairKey,Value? You say that a typical use case has
eight entries; that's a very small number where a well-tuned vector could
easily beat the O(1) of QHash or the O(log n) of
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/
---
Review request for kdelibs.
Repository: kdelibs
Description
---
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113355/#review42034
---
This really is just awesome!
Thank you very much for this
29 matches
Mail list logo
