Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/#review43682 --- This review has been submitted with commit

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/#review43683 --- This review has been submitted with commit

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-12 Thread Wolfgang Bauer
Am Sonntag, 10. November 2013, 10:32:08 schrieb Michael Pyne: I would recommend applying the patch to 4.11 and master and then investigating whether QProcess would be suitable for master (this might also help with KF5 and Windows porting, not that I expect KInfoCenter to do great things on

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/#review43419 --- This review has been submitted with commit

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-11 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/ --- (Updated Nov. 11, 2013, 11:31 a.m.) Status -- This change has been

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-10 Thread Rolf Eike Beer
ReadPipe() doesn't return 0 as expected in the case that the command is not found. but the length of sh's output which is command not found in this case. This is because popen() does not fail if the command is not found, because it _can_ run sh. (according to the man page, popen calls /bin/sh

RE: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-10 Thread Wolfgang Bauer
-Original Message- From: Rolf Eike Beer [mailto:k...@opensource.sf-tec.de] Sent: Sunday, November 10, 2013 9:11 AM To: kde-core-devel@kde.org; Wolfgang Bauer Cc: David Stephen Hubner Subject: Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-10 Thread Michael Pyne
On Sun, November 10, 2013 11:18:19 Wolfgang Bauer wrote: -Original Message- From: Rolf Eike Beer [mailto:k...@opensource.sf-tec.de] Sent: Sunday, November 10, 2013 9:11 AM To: kde-core-devel@kde.org; Wolfgang Bauer Cc: David Stephen Hubner Subject: Re: Review Request 113779:

Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-09 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/ --- Review request for kde-workspace and David Stephen Hubner. Bugs: 327382

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-09 Thread David Stephen Hubner
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/#review43314 --- Ship it! Looks good to me - David Stephen Hubner On Nov.