Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2014-01-11 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113866/ --- (Updated Jan. 11, 2014, 4:34 p.m.) Status -- This change has been ma

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2014-01-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113866/#review47206 --- This review has been submitted with commit 9437d7700cff0331cc

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2013-12-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/#review45846 --- Ship it! Looks good, please push to KDE 4.12, I'll merge upwar

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2013-12-16 Thread Stefan Brüns
> On Nov. 26, 2013, 4:34 p.m., David Faure wrote: > > kio/bookmarks/kbookmark.cc, line 251 > > > > > > firstChildElement returns a QDomElement, you should declare the > > variable as such, to avoid the toElement(

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2013-12-16 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/ --- (Updated Dec. 16, 2013, 6:33 p.m.) Review request for kdelibs and Frank Re

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2013-11-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/#review44510 --- Ship it! Looks good, just one improvement below: kio/bookmar

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2013-11-15 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/ --- (Updated Nov. 15, 2013, 2:06 p.m.) Review request for kdelibs and Frank Re