Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/#review77183 --- Just pushed it to the framework repo as http://commits.kde.or

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/ --- (Updated May 8, 2014, 10:45 p.m.) Status -- This change has been mar

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/#review57618 --- This review has been submitted with commit e132310135b2d87cbc

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/#review57617 --- Ship it! Ship It! - David Faure On April 22, 2014, 10:13 a

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/ --- (Updated April 22, 2014, 6:13 a.m.) Review request for kdelibs, David Fau

Re: Review Request 113969: Do not assume every items have the same height

> On April 6, 2014, 7:48 a.m., David Faure wrote: > > kdeui/itemviews/kcategorizedview.cpp, line 795 > > > > > > Coding style comment: some code paths use "break" (which results in > > return QModelIndex() at th

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/#review55062 --- I don't know this code so unfortunately I can't really approve

Re: Review Request 113969: Do not assume every items have the same height

> On Nov. 20, 2013, 5:27 p.m., Christoph Feck wrote: > > I love people who report bugs, and one year later come up with a patch :P > > > > Anyway, nice analysis, and this probably also fixes bug 290971, but have > > not tested it yet. > > Yichao Yu wrote: > Unfortunately I think I can stil

Re: Review Request 113969: Do not assume every items have the same height

> On Nov. 20, 2013, 5:27 p.m., Christoph Feck wrote: > > I love people who report bugs, and one year later come up with a patch :P > > > > Anyway, nice analysis, and this probably also fixes bug 290971, but have > > not tested it yet. Unfortunately I think I can still reproduce those problems.

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/#review44071 --- I love people who report bugs, and one year later come up with

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 4:47 p.m.) Review request for kdelibs, David Faure

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 4:46 p.m.) Review request for kdelibs, David Faure

Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- Review request for kdelibs, David Faure, Rafael Fernández López, and Michael

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 12:24 p.m.) Review request for kdelibs, David Faur