Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-04 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/ --- Review request for kde-workspace and Ivan Čukić. Repository: kde-workspace

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/#review45099 --- Ship it! ksplash/ksplashqml/SplashApp.cpp

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-04 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/#review45154 --- ksplash/ksplashqml/SplashApp.cpp

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-05 Thread Harald Sitter
> On Dec. 5, 2013, 12:23 a.m., Pino Toscano wrote: > > ksplash/ksplashqml/SplashApp.cpp, lines 148-150 > > > > > > What about just calling > > ::exit(2) > > to reach the stdlib function, avoiding the exi

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/#review45167 --- This review has been submitted with commit 3ab6ca57de19ed1559a

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-05 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/ --- (Updated Dec. 5, 2013, 10:14 a.m.) Status -- This change has been mar