---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114715/#review49478
---
This review has been submitted with commit
On Jan. 24, 2014, 4:32 p.m., David Faure wrote:
Urgh - a static object in a library? How did we not notice before... Needs
to be fixed indeed.
I would have used Q_GLOBAL_STATIC (which has methods like isDestroyed()),
but I guess that's equivalent to your sharedpointer + strong ref
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114715/#review48434
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114715/#review48435
---
This review has been submitted with commit
On Jan. 24, 2014, 4:32 p.m., David Faure wrote:
Urgh - a static object in a library? How did we not notice before... Needs
to be fixed indeed.
I would have used Q_GLOBAL_STATIC (which has methods like isDestroyed()),
but I guess that's equivalent to your sharedpointer + strong ref
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114715/#review48232
---
Ship it!
Urgh - a static object in a library? How did we not
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114715/#review47255
---
As discussed on the mailing list, I think that this is a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114715/
---
(Updated Jan. 3, 2014, 5:52 p.m.)
Review request for kdelibs and Frank